Re: [PATCH] softmmu: fix watchpoint processing in icount mode

2021-10-21 Thread Pavel Dovgalyuk
On 10.09.2021 17:41, Richard Henderson wrote: On 9/10/21 3:46 PM, David Hildenbrand wrote: On 10.09.21 15:34, Richard Henderson wrote: On 9/10/21 1:15 PM, David Hildenbrand wrote: On 07.09.21 13:30, Pavel Dovgalyuk wrote: Watchpoint processing code restores vCPU state twice: in tb_check_watch

Re: [PATCH] softmmu: fix watchpoint processing in icount mode

2021-09-10 Thread Richard Henderson
On 9/10/21 3:46 PM, David Hildenbrand wrote: On 10.09.21 15:34, Richard Henderson wrote: On 9/10/21 1:15 PM, David Hildenbrand wrote: On 07.09.21 13:30, Pavel Dovgalyuk wrote: Watchpoint processing code restores vCPU state twice: in tb_check_watchpoint and in cpu_loop_exit_restore/cpu_restore_

Re: [PATCH] softmmu: fix watchpoint processing in icount mode

2021-09-10 Thread David Hildenbrand
On 10.09.21 15:34, Richard Henderson wrote: On 9/10/21 1:15 PM, David Hildenbrand wrote: On 07.09.21 13:30, Pavel Dovgalyuk wrote: Watchpoint processing code restores vCPU state twice: in tb_check_watchpoint and in cpu_loop_exit_restore/cpu_restore_state. Normally it does not affect anything, b

Re: [PATCH] softmmu: fix watchpoint processing in icount mode

2021-09-10 Thread Richard Henderson
On 9/10/21 1:15 PM, David Hildenbrand wrote: On 07.09.21 13:30, Pavel Dovgalyuk wrote: Watchpoint processing code restores vCPU state twice: in tb_check_watchpoint and in cpu_loop_exit_restore/cpu_restore_state. Normally it does not affect anything, but in icount mode instruction counter is incr

Re: [PATCH] softmmu: fix watchpoint processing in icount mode

2021-09-10 Thread David Hildenbrand
On 07.09.21 13:30, Pavel Dovgalyuk wrote: Watchpoint processing code restores vCPU state twice: in tb_check_watchpoint and in cpu_loop_exit_restore/cpu_restore_state. Normally it does not affect anything, but in icount mode instruction counter is incremented twice and becomes incorrect. This patc