Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-10-24 Thread Michael Tokarev
26.09.2024 11:12, Michael S. Tsirkin wrote: On Thu, Sep 26, 2024 at 10:58:57AM +0300, Michael Tokarev wrote: 25.09.2024 13:23, Mattias Nissler wrote: On Wed, Sep 25, 2024 at 12:03 PM Michael Tokarev wrote: .. So, the issue has now become CVE-2024-8612 (information leak), with this commit (v9

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-26 Thread Michael S. Tsirkin
On Thu, Sep 26, 2024 at 10:58:57AM +0300, Michael Tokarev wrote: > 25.09.2024 13:23, Mattias Nissler wrote: > > On Wed, Sep 25, 2024 at 12:03 PM Michael Tokarev wrote: > .. > > > So, the issue has now become CVE-2024-8612 (information leak), with this > > > commit (v9.1.0-134-g637b0aa139) being th

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-26 Thread Michael Tokarev
25.09.2024 13:23, Mattias Nissler wrote: On Wed, Sep 25, 2024 at 12:03 PM Michael Tokarev wrote: .. So, the issue has now become CVE-2024-8612 (information leak), with this commit (v9.1.0-134-g637b0aa139) being the fix. Interesting. IIUC, this is triggered by device implementations calling d

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-25 Thread Mattias Nissler
On Wed, Sep 25, 2024 at 12:03 PM Michael Tokarev wrote: > > 19.08.2024 16:54, Mattias Nissler wrote: > > When DMA memory can't be directly accessed, as is the case when > > running the device model in a separate process without shareable DMA > > file descriptors, bounce buffering is used. > > > >

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-25 Thread Michael Tokarev
19.08.2024 16:54, Mattias Nissler wrote: When DMA memory can't be directly accessed, as is the case when running the device model in a separate process without shareable DMA file descriptors, bounce buffering is used. It is not uncommon for device models to request mapping of several DMA regions

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Mattias Nissler
On Mon, Sep 16, 2024 at 11:05 AM Peter Maydell wrote: > > On Mon, 16 Sept 2024 at 08:35, Mattias Nissler wrote: > > > > On Fri, Sep 13, 2024 at 6:47 PM Peter Maydell > > wrote: > > > > > > On Fri, 13 Sept 2024 at 16:55, Peter Xu wrote: > > > > > > > > On Thu, Sep 12, 2024 at 03:27:55PM +0100,

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Peter Maydell
On Mon, 16 Sept 2024 at 08:35, Mattias Nissler wrote: > > On Fri, Sep 13, 2024 at 6:47 PM Peter Maydell > wrote: > > > > On Fri, 13 Sept 2024 at 16:55, Peter Xu wrote: > > > > > > On Thu, Sep 12, 2024 at 03:27:55PM +0100, Peter Maydell wrote: > > > > Coverity is pretty unhappy about this trick,

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Mattias Nissler
On Fri, Sep 13, 2024 at 6:47 PM Peter Maydell wrote: > > On Fri, 13 Sept 2024 at 16:55, Peter Xu wrote: > > > > On Thu, Sep 12, 2024 at 03:27:55PM +0100, Peter Maydell wrote: > > > Coverity is pretty unhappy about this trick, because it isn't able > > > to recognise that we can figure out the add

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-13 Thread Peter Maydell
On Fri, 13 Sept 2024 at 16:55, Peter Xu wrote: > > On Thu, Sep 12, 2024 at 03:27:55PM +0100, Peter Maydell wrote: > > Coverity is pretty unhappy about this trick, because it isn't able > > to recognise that we can figure out the address of 'bounce' > > from the address of 'bounce->buffer' and free

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-13 Thread Peter Xu
On Thu, Sep 12, 2024 at 03:27:55PM +0100, Peter Maydell wrote: > On Mon, 19 Aug 2024 at 14:56, Mattias Nissler wrote: > > > > When DMA memory can't be directly accessed, as is the case when > > running the device model in a separate process without shareable DMA > > file descriptors, bounce buffer

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-12 Thread Peter Maydell
On Mon, 19 Aug 2024 at 14:56, Mattias Nissler wrote: > > When DMA memory can't be directly accessed, as is the case when > running the device model in a separate process without shareable DMA > file descriptors, bounce buffering is used. > > It is not uncommon for device models to request mapping

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-11 Thread Mattias Nissler
On Wed, Sep 11, 2024 at 12:24 PM Michael S. Tsirkin wrote: > > On Tue, Sep 10, 2024 at 11:36:08PM +0200, Mattias Nissler wrote: > > On Tue, Sep 10, 2024 at 6:40 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Sep 10, 2024 at 06:10:50PM +0200, Mattias Nissler wrote: > > > > On Tue, Sep 10, 2024 a

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-11 Thread Michael S. Tsirkin
On Tue, Sep 10, 2024 at 11:36:08PM +0200, Mattias Nissler wrote: > On Tue, Sep 10, 2024 at 6:40 PM Michael S. Tsirkin wrote: > > > > On Tue, Sep 10, 2024 at 06:10:50PM +0200, Mattias Nissler wrote: > > > On Tue, Sep 10, 2024 at 5:44 PM Peter Maydell > > > wrote: > > > > > > > > On Tue, 10 Sept 2

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-10 Thread Mattias Nissler
On Tue, Sep 10, 2024 at 6:40 PM Michael S. Tsirkin wrote: > > On Tue, Sep 10, 2024 at 06:10:50PM +0200, Mattias Nissler wrote: > > On Tue, Sep 10, 2024 at 5:44 PM Peter Maydell > > wrote: > > > > > > On Tue, 10 Sept 2024 at 15:53, Michael S. Tsirkin wrote: > > > > > > > > On Mon, Aug 19, 2024 a

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-10 Thread Michael S. Tsirkin
On Tue, Sep 10, 2024 at 06:10:50PM +0200, Mattias Nissler wrote: > On Tue, Sep 10, 2024 at 5:44 PM Peter Maydell > wrote: > > > > On Tue, 10 Sept 2024 at 15:53, Michael S. Tsirkin wrote: > > > > > > On Mon, Aug 19, 2024 at 06:54:54AM -0700, Mattias Nissler wrote: > > > > When DMA memory can't be

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-10 Thread Mattias Nissler
On Tue, Sep 10, 2024 at 5:44 PM Peter Maydell wrote: > > On Tue, 10 Sept 2024 at 15:53, Michael S. Tsirkin wrote: > > > > On Mon, Aug 19, 2024 at 06:54:54AM -0700, Mattias Nissler wrote: > > > When DMA memory can't be directly accessed, as is the case when > > > running the device model in a sepa

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 15:53, Michael S. Tsirkin wrote: > > On Mon, Aug 19, 2024 at 06:54:54AM -0700, Mattias Nissler wrote: > > When DMA memory can't be directly accessed, as is the case when > > running the device model in a separate process without shareable DMA > > file descriptors, bounce bu

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-10 Thread Michael S. Tsirkin
On Mon, Aug 19, 2024 at 06:54:54AM -0700, Mattias Nissler wrote: > When DMA memory can't be directly accessed, as is the case when > running the device model in a separate process without shareable DMA > file descriptors, bounce buffering is used. > > It is not uncommon for device models to reques

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-08-21 Thread Peter Xu
On Mon, Aug 19, 2024 at 06:54:54AM -0700, Mattias Nissler wrote: > When DMA memory can't be directly accessed, as is the case when > running the device model in a separate process without shareable DMA > file descriptors, bounce buffering is used. > > It is not uncommon for device models to reques