Re: [PATCH] s390x/event-facility: fix error propagation

2020-01-21 Thread Cornelia Huck
On Tue, 21 Jan 2020 10:55:06 +0100 Cornelia Huck wrote: > We currently check (by error) if the passed-in Error pointer errp > is non-null and return after realizing the first child of the > event facility in that case. Symptom is that 'virsh shutdown' > does not work, as the sclpquiesce device is

Re: [PATCH] s390x/event-facility: fix error propagation

2020-01-21 Thread Markus Armbruster
Cornelia Huck writes: > We currently check (by error) if the passed-in Error pointer errp > is non-null and return after realizing the first child of the > event facility in that case. Symptom is that 'virsh shutdown' > does not work, as the sclpquiesce device is not realized. > > Fix this by (co

Re: [PATCH] s390x/event-facility: fix error propagation

2020-01-21 Thread Thomas Huth
On 21/01/2020 10.55, Cornelia Huck wrote: > We currently check (by error) if the passed-in Error pointer errp > is non-null and return after realizing the first child of the > event facility in that case. Symptom is that 'virsh shutdown' > does not work, as the sclpquiesce device is not realized. >

Re: [PATCH] s390x/event-facility: fix error propagation

2020-01-21 Thread Christian Borntraeger
On 21.01.20 10:55, Cornelia Huck wrote: > We currently check (by error) if the passed-in Error pointer errp > is non-null and return after realizing the first child of the > event facility in that case. Symptom is that 'virsh shutdown' > does not work, as the sclpquiesce device is not realized.

Re: [PATCH] s390x/event-facility: fix error propagation

2020-01-21 Thread David Hildenbrand
On 21.01.20 10:55, Cornelia Huck wrote: > We currently check (by error) if the passed-in Error pointer errp > is non-null and return after realizing the first child of the > event facility in that case. Symptom is that 'virsh shutdown' > does not work, as the sclpquiesce device is not realized. >