Re: [PATCH] replication: compile out some staff when replication is not configured

2023-04-19 Thread Vladimir Sementsov-Ogievskiy
On 11.04.23 17:51, Vladimir Sementsov-Ogievskiy wrote: Don't compile-in replication-related files when replication is disabled in config. Signed-off-by: Vladimir Sementsov-Ogievskiy v2 will be called "[PATCH v2 0/4] COLO: improve build options" -- Best regards, Vladimir

Re: [PATCH] replication: compile out some staff when replication is not configured

2023-04-19 Thread Vladimir Sementsov-Ogievskiy
...@redhat.com; ebl...@redhat.com; jasow...@redhat.com; dgilb...@redhat.com; quint...@redhat.com; hre...@redhat.com; kw...@redhat.com; Zhang, Hailiang ; lizhij...@fujitsu.com; wencongya...@huawei.com; xiechanglon...@gmail.com; den- plotni...@yandex-team.ru Subject: Re: [PATCH] replication: compile out some

Re: [PATCH] replication: compile out some staff when replication is not configured

2023-04-17 Thread Vladimir Sementsov-Ogievskiy
...@redhat.com; quint...@redhat.com; hre...@redhat.com; kw...@redhat.com; Zhang, Hailiang ; lizhij...@fujitsu.com; wencongya...@huawei.com; xiechanglon...@gmail.com; den- plotni...@yandex-team.ru Subject: Re: [PATCH] replication: compile out some staff when replication is not configured On 14.04.23 04

RE: [PATCH] replication: compile out some staff when replication is not configured

2023-04-16 Thread Zhang, Chen
edhat.com; > quint...@redhat.com; hre...@redhat.com; kw...@redhat.com; Zhang, > Hailiang ; lizhij...@fujitsu.com; > wencongya...@huawei.com; xiechanglon...@gmail.com; den- > plotni...@yandex-team.ru > Subject: Re: [PATCH] replication: compile out some staff when replication is > not conf

Re: [PATCH] replication: compile out some staff when replication is not configured

2023-04-14 Thread Vladimir Sementsov-Ogievskiy
On 14.04.23 04:24, Zhang, Chen wrote: So, if I want to have an option to disable all COLO modules, do you mean it should be additional --disable-colo option? Or better keep one option -- disable-replication (and, maybe just rename to to --disable-colo)? I think keep the option --disable-replicat

RE: [PATCH] replication: compile out some staff when replication is not configured

2023-04-13 Thread Zhang, Chen
otni...@yandex-team.ru > Subject: Re: [PATCH] replication: compile out some staff when replication is > not configured > > On 13.04.23 12:52, Zhang, Chen wrote: > > > > > >> -Original Message- > >> From: Vladimir Sementsov-Ogievskiy > >>

Re: [PATCH] replication: compile out some staff when replication is not configured

2023-04-13 Thread Vladimir Sementsov-Ogievskiy
On 13.04.23 12:52, Zhang, Chen wrote: -Original Message- From: Vladimir Sementsov-Ogievskiy Sent: Tuesday, April 11, 2023 10:51 PM To: qemu-devel@nongnu.org Cc: qemu-bl...@nongnu.org; pbonz...@redhat.com; arm...@redhat.com; ebl...@redhat.com; jasow...@redhat.com; dgilb...@redhat.com;

RE: [PATCH] replication: compile out some staff when replication is not configured

2023-04-13 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Tuesday, April 11, 2023 10:51 PM > To: qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; pbonz...@redhat.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; dgilb...@redhat.com; > quint...@redhat.com; hre..

Re: [PATCH] replication: compile out some staff when replication is not configured

2023-04-13 Thread Daniil Tatianin
Just a few minor nits On 4/11/23 5:51 PM, Vladimir Sementsov-Ogievskiy wrote: Don't compile-in replication-related files when replication is disabled in config. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! I'm unsure, should it be actually separate --disable-colo / --enable-colo o