Re: [PATCH] replay: improve determinism of virtio-net

2021-10-20 Thread Michael S. Tsirkin
On Wed, Oct 20, 2021 at 02:40:18PM +0100, Alex Bennée wrote: > > Pavel Dovgalyuk writes: > > > On 31.05.2021 07:55, Jason Wang wrote: > >> 在 2021/5/17 下午9:04, Pavel Dovgalyuk 写道: > > >>> @@ -2546,7 +2547,7 @@ static void > >>> virtio_net_handle_tx_bh(VirtIODevice *vdev, VirtQueue *vq) > >>>    

Re: [PATCH] replay: improve determinism of virtio-net

2021-10-20 Thread Alex Bennée
Pavel Dovgalyuk writes: > On 31.05.2021 07:55, Jason Wang wrote: >> 在 2021/5/17 下午9:04, Pavel Dovgalyuk 写道: >>> @@ -2546,7 +2547,7 @@ static void >>> virtio_net_handle_tx_bh(VirtIODevice *vdev, VirtQueue *vq) >>>   return; >>>   } >>>   virtio_queue_set_notification(vq, 0); >>>

Re: [PATCH] replay: improve determinism of virtio-net

2021-07-02 Thread Philippe Mathieu-Daudé
On 5/17/21 3:04 PM, Pavel Dovgalyuk wrote: > virtio-net device uses bottom halves for callbacks. > These callbacks should be deterministic, because they affect VM state. > This patch replaces BH invocations with corresponding replay functions, > making them deterministic in record/replay mode. ^ T

Re: [PATCH] replay: improve determinism of virtio-net

2021-07-02 Thread Michael S. Tsirkin
On Mon, May 17, 2021 at 04:04:20PM +0300, Pavel Dovgalyuk wrote: > virtio-net device uses bottom halves for callbacks. > These callbacks should be deterministic, because they affect VM state. > This patch replaces BH invocations with corresponding replay functions, > making them deterministic in re

Re: [PATCH] replay: improve determinism of virtio-net

2021-06-01 Thread Pavel Dovgalyuk
On 31.05.2021 09:39, Jason Wang wrote: 在 2021/5/31 下午2:35, Pavel Dovgalyuk 写道: On 31.05.2021 07:55, Jason Wang wrote: 在 2021/5/17 下午9:04, Pavel Dovgalyuk 写道: virtio-net device uses bottom halves for callbacks. These callbacks should be deterministic, because they affect VM state. This patch

Re: [PATCH] replay: improve determinism of virtio-net

2021-05-31 Thread Pavel Dovgalyuk
On 31.05.2021 09:39, Jason Wang wrote: 在 2021/5/31 下午2:35, Pavel Dovgalyuk 写道: On 31.05.2021 07:55, Jason Wang wrote: 在 2021/5/17 下午9:04, Pavel Dovgalyuk 写道: virtio-net device uses bottom halves for callbacks. These callbacks should be deterministic, because they affect VM state. This patch

Re: [PATCH] replay: improve determinism of virtio-net

2021-05-30 Thread Jason Wang
在 2021/5/31 下午2:35, Pavel Dovgalyuk 写道: On 31.05.2021 07:55, Jason Wang wrote: 在 2021/5/17 下午9:04, Pavel Dovgalyuk 写道: virtio-net device uses bottom halves for callbacks. These callbacks should be deterministic, because they affect VM state. This patch replaces BH invocations with correspond

Re: [PATCH] replay: improve determinism of virtio-net

2021-05-30 Thread Pavel Dovgalyuk
On 31.05.2021 07:55, Jason Wang wrote: 在 2021/5/17 下午9:04, Pavel Dovgalyuk 写道: virtio-net device uses bottom halves for callbacks. These callbacks should be deterministic, because they affect VM state. This patch replaces BH invocations with corresponding replay functions, making them determini

Re: [PATCH] replay: improve determinism of virtio-net

2021-05-30 Thread Jason Wang
在 2021/5/17 下午9:04, Pavel Dovgalyuk 写道: virtio-net device uses bottom halves for callbacks. These callbacks should be deterministic, because they affect VM state. This patch replaces BH invocations with corresponding replay functions, making them deterministic in record/replay mode. This patch

Re: [PATCH] replay: improve determinism of virtio-net

2021-05-30 Thread Pavel Dovgalyuk
ping On 17.05.2021 16:04, Pavel Dovgalyuk wrote: virtio-net device uses bottom halves for callbacks. These callbacks should be deterministic, because they affect VM state. This patch replaces BH invocations with corresponding replay functions, making them deterministic in record/replay mode. Thi