Re: [PATCH] qemu-edid: drop cast

2020-10-13 Thread Daniel P . Berrangé
On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote: > Not needed and makes some compilers error out with: > > qemu-edid.c:15:1: error: initializer element is not constant > > Signed-off-by: Gerd Hoffmann > --- > qemu-edid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] qemu-edid: drop cast

2020-10-13 Thread Daniel P . Berrangé
On Tue, Oct 13, 2020 at 12:34:46PM +0200, Gerd Hoffmann wrote: > On Tue, Oct 13, 2020 at 10:23:22AM +0100, Daniel P. Berrangé wrote: > > On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote: > > > Not needed and makes some compilers error out with: > > > > > > qemu-edid.c:15:1: error:

Re: [PATCH] qemu-edid: drop cast

2020-10-13 Thread Gerd Hoffmann
On Tue, Oct 13, 2020 at 10:23:22AM +0100, Daniel P. Berrangé wrote: > On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote: > > Not needed and makes some compilers error out with: > > > > qemu-edid.c:15:1: error: initializer element is not constant > > Which compilers do this. If we're

Re: [PATCH] qemu-edid: drop cast

2020-10-13 Thread Daniel P . Berrangé
On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote: > Not needed and makes some compilers error out with: > > qemu-edid.c:15:1: error: initializer element is not constant Which compilers do this. If we're not seeing this failure in our CI, then we have a CI gap that likely needs fillin