Re: [PATCH] pmu: fix pmu vmstate subsection list

2021-11-17 Thread Cédric Le Goater
On 11/16/21 16:08, Laurent Vivier wrote: The subsection is not closed by a NULL marker so this can trigger a segfault when the pmu vmstate is saved. This can be easily shown with: $ ./qemu-system-ppc64 -dump-vmstate vmstate.json Segmentation fault (core dumped) Fixes: d811d61fbc6c ("mac

Re: [PATCH] pmu: fix pmu vmstate subsection list

2021-11-17 Thread Cédric Le Goater
diff --git a/hw/misc/macio/pmu.c b/hw/misc/macio/pmu.c index 4ad4f50e08c3..eb39c64694aa 100644 --- a/hw/misc/macio/pmu.c +++ b/hw/misc/macio/pmu.c @@ -718,6 +718,7 @@ static const VMStateDescription vmstate_pmu = { }, .subsections = (const VMStateDescription * []) { &vmstate_

Re: [PATCH] pmu: fix pmu vmstate subsection list

2021-11-16 Thread Mark Cave-Ayland
On 16/11/2021 15:08, Laurent Vivier wrote: The subsection is not closed by a NULL marker so this can trigger a segfault when the pmu vmstate is saved. This can be easily shown with: $ ./qemu-system-ppc64 -dump-vmstate vmstate.json Segmentation fault (core dumped) Fixes: d811d61fbc6c ("

Re: [PATCH] pmu: fix pmu vmstate subsection list

2021-11-16 Thread Philippe Mathieu-Daudé
On 11/16/21 16:08, Laurent Vivier wrote: > The subsection is not closed by a NULL marker so this can trigger > a segfault when the pmu vmstate is saved. > > This can be easily shown with: > > $ ./qemu-system-ppc64 -dump-vmstate vmstate.json > Segmentation fault (core dumped) > > Fixes: d811

Re: [PATCH] pmu: fix pmu vmstate subsection list

2021-11-16 Thread Greg Kurz
On Tue, 16 Nov 2021 16:08:37 +0100 Laurent Vivier wrote: > The subsection is not closed by a NULL marker so this can trigger > a segfault when the pmu vmstate is saved. > > This can be easily shown with: > > $ ./qemu-system-ppc64 -dump-vmstate vmstate.json > Segmentation fault (core dumped