Re: [PATCH] migration: ram block cpr blockers

2025-02-25 Thread Steven Sistare
On 2/18/2025 11:10 AM, Peter Xu wrote: On Fri, Feb 14, 2025 at 03:12:22PM -0500, Steven Sistare wrote: On 1/30/2025 12:01 PM, Peter Xu wrote: On Wed, Jan 29, 2025 at 01:20:13PM -0500, Steven Sistare wrote: On 1/17/2025 6:57 PM, Peter Xu wrote: On Fri, Jan 17, 2025 at 02:10:14PM -0500, Steven

Re: [PATCH] migration: ram block cpr blockers

2025-02-18 Thread Peter Xu
On Fri, Feb 14, 2025 at 03:12:22PM -0500, Steven Sistare wrote: > On 1/30/2025 12:01 PM, Peter Xu wrote: > > On Wed, Jan 29, 2025 at 01:20:13PM -0500, Steven Sistare wrote: > > > On 1/17/2025 6:57 PM, Peter Xu wrote: > > > > On Fri, Jan 17, 2025 at 02:10:14PM -0500, Steven Sistare wrote: > > > > >

Re: [PATCH] migration: ram block cpr blockers

2025-02-14 Thread Steven Sistare
On 1/30/2025 12:01 PM, Peter Xu wrote: On Wed, Jan 29, 2025 at 01:20:13PM -0500, Steven Sistare wrote: On 1/17/2025 6:57 PM, Peter Xu wrote: On Fri, Jan 17, 2025 at 02:10:14PM -0500, Steven Sistare wrote: On 1/17/2025 1:16 PM, Peter Xu wrote: On Fri, Jan 17, 2025 at 09:46:11AM -0800, Steve Si

Re: [PATCH] migration: ram block cpr blockers

2025-01-30 Thread Peter Xu
On Wed, Jan 29, 2025 at 01:20:13PM -0500, Steven Sistare wrote: > On 1/17/2025 6:57 PM, Peter Xu wrote: > > On Fri, Jan 17, 2025 at 02:10:14PM -0500, Steven Sistare wrote: > > > On 1/17/2025 1:16 PM, Peter Xu wrote: > > > > On Fri, Jan 17, 2025 at 09:46:11AM -0800, Steve Sistare wrote: > > > > > +/

Re: [PATCH] migration: ram block cpr blockers

2025-01-29 Thread Steven Sistare
On 1/17/2025 6:57 PM, Peter Xu wrote: On Fri, Jan 17, 2025 at 02:10:14PM -0500, Steven Sistare wrote: On 1/17/2025 1:16 PM, Peter Xu wrote: On Fri, Jan 17, 2025 at 09:46:11AM -0800, Steve Sistare wrote: +/* + * Return true if ram contents would be lost during CPR. + * Return false for ram_devi

Re: [PATCH] migration: ram block cpr blockers

2025-01-17 Thread Peter Xu
On Fri, Jan 17, 2025 at 02:10:14PM -0500, Steven Sistare wrote: > On 1/17/2025 1:16 PM, Peter Xu wrote: > > On Fri, Jan 17, 2025 at 09:46:11AM -0800, Steve Sistare wrote: > > > +/* > > > + * Return true if ram contents would be lost during CPR. > > > + * Return false for ram_device because it is re

Re: [PATCH] migration: ram block cpr blockers

2025-01-17 Thread Steven Sistare
On 1/17/2025 1:16 PM, Peter Xu wrote: On Fri, Jan 17, 2025 at 09:46:11AM -0800, Steve Sistare wrote: +/* + * Return true if ram contents would be lost during CPR. + * Return false for ram_device because it is remapped in new QEMU. Do not + * exclude rom, even though it is readonly, because the

Re: [PATCH] migration: ram block cpr blockers

2025-01-17 Thread Peter Xu
On Fri, Jan 17, 2025 at 09:46:11AM -0800, Steve Sistare wrote: > +/* > + * Return true if ram contents would be lost during CPR. > + * Return false for ram_device because it is remapped in new QEMU. Do not > + * exclude rom, even though it is readonly, because the rom file could change > + * in ne