Re: [PATCH] migration: Plug memory leak on HMP migrate error path

2024-01-23 Thread Markus Armbruster
Peter Xu writes: > On Tue, Jan 23, 2024 at 04:33:43PM +, Peter Maydell wrote: >> On Wed, 17 Jan 2024 at 19:49, Markus Armbruster wrote: >> > >> > hmp_migrate() leaks @caps when qmp_migrate() fails. Plug the leak >> > with g_autoptr(). >> > >> > Fixes: 967f2de5c9ec (migration: Implement Migr

Re: [PATCH] migration: Plug memory leak on HMP migrate error path

2024-01-23 Thread Peter Xu
On Tue, Jan 23, 2024 at 04:33:43PM +, Peter Maydell wrote: > On Wed, 17 Jan 2024 at 19:49, Markus Armbruster wrote: > > > > hmp_migrate() leaks @caps when qmp_migrate() fails. Plug the leak > > with g_autoptr(). > > > > Fixes: 967f2de5c9ec (migration: Implement MigrateChannelList to hmp > >

Re: [PATCH] migration: Plug memory leak on HMP migrate error path

2024-01-23 Thread Peter Maydell
On Wed, 17 Jan 2024 at 19:49, Markus Armbruster wrote: > > hmp_migrate() leaks @caps when qmp_migrate() fails. Plug the leak > with g_autoptr(). > > Fixes: 967f2de5c9ec (migration: Implement MigrateChannelList to hmp migration > flow.) v8.2.0-rc0 > Fixes: CID 1533124 Isn't this 1533125 ? 153312

Re: [PATCH] migration: Plug memory leak on HMP migrate error path

2024-01-17 Thread Peter Xu
On Wed, Jan 17, 2024 at 03:07:22PM +0100, Markus Armbruster wrote: > hmp_migrate() leaks @caps when qmp_migrate() fails. Plug the leak > with g_autoptr(). > > Fixes: 967f2de5c9ec (migration: Implement MigrateChannelList to hmp migration > flow.) v8.2.0-rc0 > Fixes: CID 1533124 > Signed-off-by: M