Re: [PATCH] migration: Fix parse_ramblock() on overwritten retvals

2023-10-19 Thread Peter Xu
On Thu, Oct 19, 2023 at 01:40:29PM +0100, Peter Maydell wrote: > On Tue, 17 Oct 2023 at 21:40, Peter Xu wrote: > > > > It's possible that some errors can be overwritten with success retval later > > on, and then ignored. Always capture all errors and report. > > > > Reported by Coverity 1522861,

Re: [PATCH] migration: Fix parse_ramblock() on overwritten retvals

2023-10-19 Thread Peter Maydell
On Tue, 17 Oct 2023 at 21:40, Peter Xu wrote: > > It's possible that some errors can be overwritten with success retval later > on, and then ignored. Always capture all errors and report. > > Reported by Coverity 1522861, but actually I spot one more in the same > function. The other one is CID

Re: [PATCH] migration: Fix parse_ramblock() on overwritten retvals

2023-10-18 Thread Juan Quintela
Peter Xu wrote: > It's possible that some errors can be overwritten with success retval later > on, and then ignored. Always capture all errors and report. > > Reported by Coverity 1522861, but actually I spot one more in the same > function. > > Fixes: CID 1522861 > Signed-off-by: Peter Xu Re

Re: [PATCH] migration: Fix parse_ramblock() on overwritten retvals

2023-10-18 Thread Peter Xu
On Wed, Oct 18, 2023 at 09:12:36AM +0200, Juan Quintela wrote: > Peter Xu wrote: > > It's possible that some errors can be overwritten with success retval later > > on, and then ignored. Always capture all errors and report. > > > > Reported by Coverity 1522861, but actually I spot one more in th

Re: [PATCH] migration: Fix parse_ramblock() on overwritten retvals

2023-10-18 Thread Juan Quintela
Peter Xu wrote: > It's possible that some errors can be overwritten with success retval later > on, and then ignored. Always capture all errors and report. > > Reported by Coverity 1522861, but actually I spot one more in the same > function. > > Fixes: CID 1522861 > Signed-off-by: Peter Xu > --

Re: [PATCH] migration: Fix parse_ramblock() on overwritten retvals

2023-10-17 Thread Fabiano Rosas
Peter Xu writes: > It's possible that some errors can be overwritten with success retval later > on, and then ignored. Always capture all errors and report. > > Reported by Coverity 1522861, but actually I spot one more in the same > function. > > Fixes: CID 1522861 > Signed-off-by: Peter Xu R