Re: [PATCH] io: error_prepend() in qio_channel_readv_full_all() causes segfault

2021-02-12 Thread Jag Raman
> On Feb 12, 2021, at 8:08 AM, Eric Blake wrote: > > On 2/12/21 5:41 AM, Jag Raman wrote: >> >> >>> On Feb 12, 2021, at 6:16 AM, Daniel P. Berrangé wrote: >>> >>> On Fri, Feb 12, 2021 at 06:16:07AM -0500, Jagannathan Raman wrote: Using error_prepend() in qio_channel_readv_full_all() ca

Re: [PATCH] io: error_prepend() in qio_channel_readv_full_all() causes segfault

2021-02-12 Thread Eric Blake
On 2/12/21 5:41 AM, Jag Raman wrote: > > >> On Feb 12, 2021, at 6:16 AM, Daniel P. Berrangé wrote: >> >> On Fri, Feb 12, 2021 at 06:16:07AM -0500, Jagannathan Raman wrote: >>> Using error_prepend() in qio_channel_readv_full_all() causes a segfault >>> as errp is not set when ret is 0. This resul

Re: [PATCH] io: error_prepend() in qio_channel_readv_full_all() causes segfault

2021-02-12 Thread Jag Raman
> On Feb 12, 2021, at 6:16 AM, Daniel P. Berrangé wrote: > > On Fri, Feb 12, 2021 at 06:16:07AM -0500, Jagannathan Raman wrote: >> Using error_prepend() in qio_channel_readv_full_all() causes a segfault >> as errp is not set when ret is 0. This results in the failure of iotest >> 83. Replacing

Re: [PATCH] io: error_prepend() in qio_channel_readv_full_all() causes segfault

2021-02-12 Thread Daniel P . Berrangé
On Fri, Feb 12, 2021 at 06:16:07AM -0500, Jagannathan Raman wrote: > Using error_prepend() in qio_channel_readv_full_all() causes a segfault > as errp is not set when ret is 0. This results in the failure of iotest > 83. Replacing with error_setg() fixes the problem. > > Additionally, removes a fu