RE: [PATCH] hw/ppc: Improve build for PPC VFIO

2023-11-24 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Sent: Friday, November 24, 2023 3:59 PM >Subject: Re: [PATCH] hw/ppc: Improve build for PPC VFIO > >Zhenzhong, > >> How about what's below  instead ? >> >> >> Thanks, >> >> C. &

Re: [PATCH] hw/ppc: Improve build for PPC VFIO

2023-11-24 Thread Cédric Le Goater
Zhenzhong, How about what's below  instead ? Thanks, C. I will resend the build fix with the proposal below since it addresses Phil's concerns. Thanks, C. --- a/hw/ppc/spapr_pci_vfio.c +++ b/hw/ppc/spapr_pci_vfio.c @@ -26,10 +26,12 @@  #include "hw/pci/pci_device.h"  #include "hw/vf

Re: [PATCH] hw/ppc: Improve build for PPC VFIO

2023-11-23 Thread Nicholas Piggin
On Thu Nov 23, 2023 at 5:33 PM AEST, Cédric Le Goater wrote: > On 11/23/23 07:01, Zhenzhong Duan wrote: > > VFIO is not a required subsystem for the pseries machine but it's > > force enabled currently. When --without-default-devices is used > > to drop some default devices including vfio-pci, vfio

Re: [PATCH] hw/ppc: Improve build for PPC VFIO

2023-11-23 Thread Cédric Le Goater
On 11/23/23 11:19, Philippe Mathieu-Daudé wrote: Hi Cédric, On 23/11/23 08:33, Cédric Le Goater wrote: On 11/23/23 07:01, Zhenzhong Duan wrote: VFIO is not a required subsystem for the pseries machine but it's force enabled currently. When --without-default-devices is used to drop some default

Re: [PATCH] hw/ppc: Improve build for PPC VFIO

2023-11-23 Thread Philippe Mathieu-Daudé
Hi Cédric, On 23/11/23 08:33, Cédric Le Goater wrote: On 11/23/23 07:01, Zhenzhong Duan wrote: VFIO is not a required subsystem for the pseries machine but it's force enabled currently. When --without-default-devices is used to drop some default devices including vfio-pci, vfio core code is sti

RE: [PATCH] hw/ppc: Improve build for PPC VFIO

2023-11-22 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Sent: Thursday, November 23, 2023 3:33 PM >Subject: Re: [PATCH] hw/ppc: Improve build for PPC VFIO > >On 11/23/23 07:01, Zhenzhong Duan wrote: >> VFIO is not a required subsystem for the pseries machine but it'

Re: [PATCH] hw/ppc: Improve build for PPC VFIO

2023-11-22 Thread Cédric Le Goater
On 11/23/23 07:01, Zhenzhong Duan wrote: VFIO is not a required subsystem for the pseries machine but it's force enabled currently. When --without-default-devices is used to drop some default devices including vfio-pci, vfio core code is still kept which is unnecessary. Introduce a stub file to