Re: [PATCH] hw/pci/pci: Fix slot check for plugged devices

2020-09-24 Thread Michael S. Tsirkin
On Wed, Sep 23, 2020 at 05:57:19PM +0200, Julia Suvorova wrote: > On Wed, Sep 23, 2020 at 5:03 PM Michael S. Tsirkin wrote: > > > > On Wed, Sep 23, 2020 at 11:26:36AM +0200, Julia Suvorova wrote: > > > If devfn is assigned automatically, 'else' clauses will never be > > > executed. And if it does

Re: [PATCH] hw/pci/pci: Fix slot check for plugged devices

2020-09-23 Thread Julia Suvorova
On Wed, Sep 23, 2020 at 5:03 PM Michael S. Tsirkin wrote: > > On Wed, Sep 23, 2020 at 11:26:36AM +0200, Julia Suvorova wrote: > > If devfn is assigned automatically, 'else' clauses will never be > > executed. And if it does not matter for the reserved and available > > devfn, because we have alrea

Re: [PATCH] hw/pci/pci: Fix slot check for plugged devices

2020-09-23 Thread Michael S. Tsirkin
On Wed, Sep 23, 2020 at 11:26:36AM +0200, Julia Suvorova wrote: > If devfn is assigned automatically, 'else' clauses will never be > executed. And if it does not matter for the reserved and available > devfn, because we have already checked it, the check for function0 > needs to be done again. > >