Re: [PATCH] hw/arm/pxa2xx: Add missing fallthrough comment

2020-09-11 Thread Laurent Vivier
Le 11/09/2020 à 14:41, Philippe Mathieu-Daudé a écrit : > On 9/11/20 2:18 PM, Thomas Huth wrote: >> Let's make this file compilable with -Werror=implicit-fallthrough : >> Looking at the code, it seems like the fallthrough is intended here, >> so we should add the corresponding "/* fallthrough */" c

Re: [PATCH] hw/arm/pxa2xx: Add missing fallthrough comment

2020-09-11 Thread Thomas Huth
On 11/09/2020 14.41, Philippe Mathieu-Daudé wrote: > On 9/11/20 2:18 PM, Thomas Huth wrote: >> Let's make this file compilable with -Werror=implicit-fallthrough : >> Looking at the code, it seems like the fallthrough is intended here, >> so we should add the corresponding "/* fallthrough */" commen

Re: [PATCH] hw/arm/pxa2xx: Add missing fallthrough comment

2020-09-11 Thread Philippe Mathieu-Daudé
On 9/11/20 2:18 PM, Thomas Huth wrote: > Let's make this file compilable with -Werror=implicit-fallthrough : > Looking at the code, it seems like the fallthrough is intended here, > so we should add the corresponding "/* fallthrough */" comment here. > > Signed-off-by: Thomas Huth > --- > hw/arm