Re: [PATCH] gitattributes: Cover Objective-C source files

2022-03-28 Thread Philippe Mathieu-Daudé
On 17/3/22 14:03, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé See comments in commit 29cf16db23 ("buildsys: Help git-diff adding .gitattributes config file") for details. Signed-off-by: Philippe Mathieu-Daudé --- .gitattributes | 1 + 1 file changed, 1 insertion(+) Not a f

Re: [PATCH] gitattributes: Cover Objective-C source files

2022-03-19 Thread Akihiko Odaki
On 2022/03/19 22:49, Philippe Mathieu-Daudé wrote: On 19/3/22 04:25, Akihiko Odaki wrote: On 2022/03/19 1:14, Philippe Mathieu-Daudé wrote: Commit 29cf16db23 says: Since commits 0979ed017f0 ("meson: rename .inc.h files to .h.inc") and 139c1837db7 ("meson: rename included C source files to .c.i

Re: [PATCH] gitattributes: Cover Objective-C source files

2022-03-19 Thread Philippe Mathieu-Daudé
On 19/3/22 04:25, Akihiko Odaki wrote: On 2022/03/19 1:14, Philippe Mathieu-Daudé wrote: Commit 29cf16db23 says: Since commits 0979ed017f0 ("meson: rename .inc.h files to .h.inc") and 139c1837db7 ("meson: rename included C source files to .c.inc") 'git-diff --function-context' stopped displayin

Re: [PATCH] gitattributes: Cover Objective-C source files

2022-03-18 Thread Akihiko Odaki
On 2022/03/19 1:14, Philippe Mathieu-Daudé wrote: Commit 29cf16db23 says: Since commits 0979ed017f0 ("meson: rename .inc.h files to .h.inc") and 139c1837db7 ("meson: rename included C source files to .c.inc") 'git-diff --function-context' stopped displaying C function context correctly. So I s

Re: [PATCH] gitattributes: Cover Objective-C source files

2022-03-18 Thread Philippe Mathieu-Daudé
On 18/3/22 15:42, Akihiko Odaki wrote: I don't think this is needed. I could see a diff annotated with a method name even without this change: % git diff diff --git a/ui/cocoa.m b/ui/cocoa.m index cb6e7c41dc6..14a4416cc8b 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1264,6 +1264,7 @@ - (id) init

Re: [PATCH] gitattributes: Cover Objective-C source files

2022-03-18 Thread Akihiko Odaki
I don't think this is needed. I could see a diff annotated with a method name even without this change: % git diff diff --git a/ui/cocoa.m b/ui/cocoa.m index cb6e7c41dc6..14a4416cc8b 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1264,6 +1264,7 @@ - (id) init [pauseLabel setTextColor: [NSC

Re: [PATCH] gitattributes: Cover Objective-C source files

2022-03-18 Thread Christian Schoenebeck
On Donnerstag, 17. März 2022 14:03:26 CET Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > See comments in commit 29cf16db23 ("buildsys: Help git-diff > adding .gitattributes config file") for details. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Christian Schoe

Re: [PATCH] gitattributes: Cover Objective-C source files

2022-03-18 Thread Philippe Mathieu-Daudé
+qemu-trivial@ On 17/3/22 14:03, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé See comments in commit 29cf16db23 ("buildsys: Help git-diff adding .gitattributes config file") for details. Signed-off-by: Philippe Mathieu-Daudé --- .gitattributes | 1 + 1 file changed, 1 insert