Re: [PATCH] chardev: clean up chardev-parallel.c

2023-01-02 Thread Marc-André Lureau
On Thu, Dec 22, 2022 at 11:42 AM Paolo Bonzini wrote: > > Replace HAVE_CHARDEV_PARPORT with a Meson conditional, remove unnecessary > defines, and close the file descriptor on FreeBSD/DragonFly. > > Signed-off-by: Paolo Bonzini > --- > chardev/char-parallel.c | 15 ++- > chardev/meso

Re: [PATCH] chardev: clean up chardev-parallel.c

2022-12-22 Thread Philippe Mathieu-Daudé
On 22/12/22 08:38, Paolo Bonzini wrote: Replace HAVE_CHARDEV_PARPORT with a Meson conditional, remove unnecessary defines, and close the file descriptor on FreeBSD/DragonFly. Signed-off-by: Paolo Bonzini --- chardev/char-parallel.c | 15 ++- chardev/meson.build | 5 - i

Re: [PATCH] chardev: clean up chardev-parallel.c

2022-12-19 Thread Philippe Mathieu-Daudé
On 19/12/22 10:17, Paolo Bonzini wrote: Replace HAVE_CHARDEV_PARPORT with a Meson conditional, remove unnecessary defines, and close the file descriptor on FreeBSD/DragonFly. Signed-off-by: Paolo Bonzini --- chardev/char-parallel.c | 15 ++- chardev/meson.build | 5 - i