Re: [PATCH] block: simplify write-threshold and drop write notifiers

2021-05-05 Thread Vladimir Sementsov-Ogievskiy
05.05.2021 13:10, Stefan Hajnoczi wrote: On Thu, Apr 22, 2021 at 01:09:50AM +0300, Vladimir Sementsov-Ogievskiy wrote: @@ -1981,8 +1985,15 @@ bdrv_co_write_req_prepare(BdrvChild *child, int64_t offset, int64_t bytes, } else { assert(child->perm & BLK_PERM_WRITE);

Re: [PATCH] block: simplify write-threshold and drop write notifiers

2021-05-05 Thread Stefan Hajnoczi
On Thu, Apr 22, 2021 at 01:09:50AM +0300, Vladimir Sementsov-Ogievskiy wrote: > @@ -1981,8 +1985,15 @@ bdrv_co_write_req_prepare(BdrvChild *child, int64_t > offset, int64_t bytes, > } else { > assert(child->perm & BLK_PERM_WRITE); > } > -return notifier_with_

Re: [PATCH] block: simplify write-threshold and drop write notifiers

2021-05-03 Thread Vladimir Sementsov-Ogievskiy
30.04.2021 13:04, Max Reitz wrote: On 22.04.21 00:09, Vladimir Sementsov-Ogievskiy wrote: write-notifiers are used only for write-threshold. New code for such purpose should create filters. Let's handle write-threshold simply in generic code and drop write notifiers at all. Also move part of w

Re: [PATCH] block: simplify write-threshold and drop write notifiers

2021-04-30 Thread Max Reitz
On 22.04.21 00:09, Vladimir Sementsov-Ogievskiy wrote: write-notifiers are used only for write-threshold. New code for such purpose should create filters. Let's handle write-threshold simply in generic code and drop write notifiers at all. Also move part of write-threshold API that is used only

Re: [PATCH] block: simplify write-threshold and drop write notifiers

2021-04-22 Thread Vladimir Sementsov-Ogievskiy
22.04.2021 12:57, Emanuele Giuseppe Esposito wrote: On 22/04/2021 00:09, Vladimir Sementsov-Ogievskiy wrote: write-notifiers are used only for write-threshold. New code for such purpose should create filters. Let's handle write-threshold simply in generic code and drop write notifiers at all.

Re: [PATCH] block: simplify write-threshold and drop write notifiers

2021-04-22 Thread Emanuele Giuseppe Esposito
On 22/04/2021 00:09, Vladimir Sementsov-Ogievskiy wrote: write-notifiers are used only for write-threshold. New code for such purpose should create filters. Let's handle write-threshold simply in generic code and drop write notifiers at all. Also move part of write-threshold API that is used