Re: [PATCH] block/nbd: fix memory leak in nbd_open()

2019-11-28 Thread pannengyuan
Thanks for you suggestion, I'd be glad to do it, I will send a new version later. Cheers. On 2019/11/28 18:41, Stefano Garzarella wrote: > On Thu, Nov 28, 2019 at 06:32:49PM +0800, pannengyuan wrote: >> Hi, >> I think it's a better way, you can implement this new function before >> this patch. >

Re: [PATCH] block/nbd: fix memory leak in nbd_open()

2019-11-28 Thread Stefano Garzarella
On Thu, Nov 28, 2019 at 06:32:49PM +0800, pannengyuan wrote: > Hi, > I think it's a better way, you can implement this new function before > this patch. If you want to do it, so you can send everything together, for me there's no problem, it was just a suggestion. If you don't have time, I can do

Re: [PATCH] block/nbd: fix memory leak in nbd_open()

2019-11-28 Thread pannengyuan
Hi, I think it's a better way, you can implement this new function before this patch. Thanks. On 2019/11/28 17:01, Stefano Garzarella wrote: > On Thu, Nov 28, 2019 at 04:40:10PM +0800, pannengy...@huawei.com wrote: > > Hi, > I don't know nbd code very well, the patch LGTM, but just a comment > b

Re: [PATCH] block/nbd: fix memory leak in nbd_open()

2019-11-28 Thread Stefano Garzarella
On Thu, Nov 28, 2019 at 04:40:10PM +0800, pannengy...@huawei.com wrote: Hi, I don't know nbd code very well, the patch LGTM, but just a comment below: > From: PanNengyuan > > In currently implementation there will be a memory leak when > nbd_client_connect() returns error status. Here is an eas