Re: [PATCH] bcm2838: Add GIC-400 timer interupt connections

2025-03-11 Thread Sourojeet Adhikari
Hello, So far I've figured out that I need to add a member called SplitIRQ in the BCMSocPeripheralBaseState struct, which is of size defined by `BCM2835_NUM_SPLITTERS`. Then from what I can tell through reading through the codebase, I should do something similar to what happens in `exynos4210.c`

Re: [PATCH] bcm2838: Add GIC-400 timer interupt connections

2025-03-11 Thread Peter Maydell
On Mon, 10 Mar 2025 at 06:29, Sourojeet Adhikari wrote: > > Hello, > > So far I've figured out that I need to add a member called SplitIRQ > in the BCMSocPeripheralBaseState struct, which is of size defined > by `BCM2835_NUM_SPLITTERS`. Then from what I can tell through > reading through the codeb

Re: [PATCH] bcm2838: Add GIC-400 timer interupt connections

2025-03-02 Thread Sourojeet Adhikari
On 2025-02-27 10:17, Peter Maydell wrote: On Thu, 27 Feb 2025 at 09:15, Sourojeet Adhikari wrote: The systmr INTERRUPT_TIMER0..3 sysbus IRQ outputs are already being wired up in the function bcm_soc_peripherals_common_realize() in hw/arm/bcm2835_peripherals.c (to the TYPE_BCM2835_IC interrupt

Re: [PATCH] bcm2838: Add GIC-400 timer interupt connections

2025-03-01 Thread Peter Maydell
On Sat, 1 Mar 2025 at 01:47, Sourojeet Adhikari wrote: > > On 2025-02-27 10:17, Peter Maydell wrote: > > On Thu, 27 Feb 2025 at 09:15, Sourojeet Adhikari > wrote: > > The systmr INTERRUPT_TIMER0..3 sysbus IRQ outputs are already > being wired up in the function bcm_soc_peripherals_common_realize(

Re: [PATCH] bcm2838: Add GIC-400 timer interupt connections

2025-02-27 Thread Peter Maydell
On Thu, 27 Feb 2025 at 09:15, Sourojeet Adhikari wrote: > > The systmr INTERRUPT_TIMER0..3 sysbus IRQ outputs are already > > being wired up in the function bcm_soc_peripherals_common_realize() > > in hw/arm/bcm2835_peripherals.c (to the TYPE_BCM2835_IC > > interrupt controller), and it isn't vali

Re: [PATCH] bcm2838: Add GIC-400 timer interupt connections

2025-02-27 Thread Sourojeet Adhikari
Hello, thank you for taking the time to review the patch, and tell us what we could improve. The values passed to qdev_get_gpio_in(DEVICE(&s->gic), ...) should be GIC_SPI_INTERRUPT_* values, which we define in include/hw/arm/bcm2838_peripherals.h. You can add new ones for the four timers. Hm,

Re: [PATCH] bcm2838: Add GIC-400 timer interupt connections

2025-02-24 Thread Peter Maydell
On Sun, 16 Feb 2025 at 03:54, Sourojeet Adhikari wrote: > > Hello everyone, > > This patch adds support for the system timer interrupts > in QEMU's BCM2838 model. It defines a new constant > called GIC400_TIMER_INT, and connects 4 timer interupts > to the GIC-400. > Previously timer interupts were