Re: [PATCH] accel/tcg/plugin: Fix inject_mem_cb rw masking

2024-06-12 Thread Pierrick Bouvier
On 6/5/24 15:39, Pierrick Bouvier wrote: Thanks for catching this Richard. I did the same mistake in plugins/core.c as well, could you fix it as well as part of this patch? For complement, rw are enums, R is 0b01, W is 0b10, and RW is 0b11, thus it work as expected with &. Thanks, Pierrick Re

Re: [PATCH] accel/tcg/plugin: Fix inject_mem_cb rw masking

2024-06-05 Thread Pierrick Bouvier
Thanks for catching this Richard. I did the same mistake in plugins/core.c as well, could you fix it as well as part of this patch? For complement, rw are enums, R is 0b01, W is 0b10, and RW is 0b11, thus it work as expected with &. Thanks, Pierrick Reviewed-by: Pierrick Bouvier On 6/5/24