Re: [PATCH] Fix duplicate symbol error on MacOS build

2025-04-04 Thread Peter Maydell
On Wed, 19 Mar 2025 at 12:53, Tanish Desai wrote: > > The issue started after commit > https://github.com/qemu/qemu/commit/59f4d65584bd3372070e2484876436c8d02505e4 > > Reproduction: > 1. In the build directory on MacOS (haven't tried on other OS), run: >../configure --enable-rust --targ

Re: [PATCH] Fix duplicate symbol error on MacOS build

2025-03-19 Thread Peter Maydell
On Wed, 19 Mar 2025 at 14:02, Tanish Desai wrote: > > It will work for PL011 but there are other devices using the same method for > selecting rust or c++ file like HPET in timer. > You can check this:- > https://github.com/qemu/qemu/blob/master/hw/timer/Kconfig > Wouldn’t it create inconsistenci

Re: [PATCH] Fix duplicate symbol error on MacOS build

2025-03-19 Thread Paolo Bonzini
On 3/19/25 14:44, Peter Maydell wrote: -select PL011 # UART +select PL011 if !HAVE_RUST # UART +select X_PL011_RUST if HAVE_RUST # UART select PL031 # RTC select PL061 # GPIO select GPIO_PWR Paolo: we seem to have quite a lot of this select PL011 if !HAVE_RUS

Re: [PATCH] Fix duplicate symbol error on MacOS build

2025-03-19 Thread Daniel P . Berrangé
On Wed, Mar 19, 2025 at 02:52:43PM +0100, Philippe Mathieu-Daudé wrote: > Cc'ing CI maintainers. > > On 19/3/25 03:30, Tanish Desai wrote: > > The issue started after commit > > https://github.com/qemu/qemu/commit/59f4d65584bd3372070e2484876436c8d02505e4 > > > > Reproduction: > >1. In the bu

Re: [PATCH] Fix duplicate symbol error on MacOS build

2025-03-19 Thread Tanish Desai
It will work for PL011 but there are other devices using the same method for selecting rust or c++ file like HPET in timer. You can check this:- https://github.com/qemu/qemu/blob/master/hw/timer/Kconfig Wouldn’t it create inconsistencies in code if we change only for PL011? On Wed, 19 Mar 2025 at

Re: [PATCH] Fix duplicate symbol error on MacOS build

2025-03-19 Thread Philippe Mathieu-Daudé
Cc'ing CI maintainers. On 19/3/25 03:30, Tanish Desai wrote: The issue started after commit https://github.com/qemu/qemu/commit/59f4d65584bd3372070e2484876436c8d02505e4 Reproduction: 1. In the build directory on MacOS (haven't tried on other OS), run: ../configure --enable-rust --ta

Re: [PATCH] Fix duplicate symbol error on MacOS build

2025-03-19 Thread Philippe Mathieu-Daudé
On 19/3/25 14:44, Peter Maydell wrote: On Wed, 19 Mar 2025 at 12:53, Tanish Desai wrote: The issue started after commit https://github.com/qemu/qemu/commit/59f4d65584bd3372070e2484876436c8d02505e4 Reproduction: 1. In the build directory on MacOS (haven't tried on other OS), run: .