Re: [PATCH v4] arm/virt: Add memory hot remove support

2020-06-25 Thread Igor Mammedov
; > > peter.mayd...@linaro.org; m...@redhat.com; Linuxarm > > ; xuwei (O) ; > > eric.au...@redhat.com; Zengtao (B) > > Subject: Re: [PATCH v4] arm/virt: Add memory hot remove support > > > > On Mon, 22 Jun 2020 13:41:57 +0100 > > Shameer Kolothum wrote: &

Re: [PATCH v4] arm/virt: Add memory hot remove support

2020-06-24 Thread Peter Maydell
On Wed, 24 Jun 2020 at 17:50, Shameerali Kolothum Thodi wrote: > > > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > doesn't pc_dimm_unplug() do unrealize already? > > (/me wonders why it doesn't explode here, > > are we leaking a refference somewhere so dim

RE: [PATCH v4] arm/virt: Add memory hot remove support

2020-06-24 Thread Shameerali Kolothum Thodi
.@redhat.com; Zengtao (B) > Subject: Re: [PATCH v4] arm/virt: Add memory hot remove support > > On Mon, 22 Jun 2020 13:41:57 +0100 > Shameer Kolothum wrote: > > > This adds support for memory(pc-dimm) hot remove on arm/virt that > > uses acpi ged device. > > &g

Re: [PATCH v4] arm/virt: Add memory hot remove support

2020-06-24 Thread Igor Mammedov
On Mon, 22 Jun 2020 13:41:57 +0100 Shameer Kolothum wrote: > This adds support for memory(pc-dimm) hot remove on arm/virt that > uses acpi ged device. > > NVDIMM hot removal is not yet supported. > > Signed-off-by: Shameer Kolothum > --- > v2 --> v3 > -Addressed Eric's comments on v3. > v2

Re: [PATCH v4] arm/virt: Add memory hot remove support

2020-06-23 Thread Peter Maydell
On Tue, 23 Jun 2020 at 11:15, Auger Eric wrote: > > Hi Shameer, > > On 6/22/20 2:41 PM, Shameer Kolothum wrote: > > This adds support for memory(pc-dimm) hot remove on arm/virt that > > uses acpi ged device. > > > > NVDIMM hot removal is not yet supported. > > > > Signed-off-by: Shameer Kolothum

Re: [PATCH v4] arm/virt: Add memory hot remove support

2020-06-23 Thread Auger Eric
Hi Shameer, On 6/22/20 2:41 PM, Shameer Kolothum wrote: > This adds support for memory(pc-dimm) hot remove on arm/virt that > uses acpi ged device. > > NVDIMM hot removal is not yet supported. > > Signed-off-by: Shameer Kolothum Works fine for me when passing "movable_node" in the guest kernel