Re: [PATCH v3] block/iscsi:use the flags in iscsi_open() prevent Clang warning

2020-03-23 Thread Kevin Wolf
Am 11.03.2020 um 04:29 hat Chen Qun geschrieben: > Clang static code analyzer show warning: > block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read > flags &= ~BDRV_O_RDWR; > ^ > > In iscsi_allocmap_init() only checks BDRV_O_NOCACHE, which > is

Re: [PATCH v3] block/iscsi:use the flags in iscsi_open() prevent Clang warning

2020-03-20 Thread Stefan Hajnoczi
On Wed, Mar 11, 2020 at 11:29:27AM +0800, Chen Qun wrote: > Clang static code analyzer show warning: > block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read > flags &= ~BDRV_O_RDWR; > ^ > > In iscsi_allocmap_init() only checks BDRV_O_NOCACHE, wh

Re: [PATCH v3] block/iscsi:use the flags in iscsi_open() prevent Clang warning

2020-03-20 Thread Laurent Vivier
Le 20/03/2020 à 03:25, Chenqun (kuhn) a écrit : > Gentle ping. > > Any other suggestions about this? I will not take that via the trivial queue as it is not trivial for me. Could it go via block queue? Thanks, Laurent > Thanks. > >> -Original Message- >> From: Chenqun (kuhn) >> Sent:

RE: [PATCH v3] block/iscsi:use the flags in iscsi_open() prevent Clang warning

2020-03-19 Thread Chenqun (kuhn)
Gentle ping. Any other suggestions about this? Thanks. >-Original Message- >From: Chenqun (kuhn) >Sent: Wednesday, March 11, 2020 11:29 AM >To: qemu-devel@nongnu.org; qemu-triv...@nongnu.org >Cc: Zhanghailiang ; Chenqun (kuhn) >; Euler Robot ; >Kevin Wolf ; Ronnie Sahlberg >; Paolo Bonzi