Re: [PATCH v26 08/17] vfio: Add save state functions to SaveVMHandlers

2020-10-21 Thread Kirti Wankhede
On 9/23/2020 5:12 PM, Wang, Zhi A wrote: I met a problem when trying this patch. Mostly the problem happens if a device doesn't set any pending bytes in the iteration stage, which shows this device doesn't have a stage of iteration. I tried to reproduce this issue at my end and I didn't hit

Re: [PATCH v26 08/17] vfio: Add save state functions to SaveVMHandlers

2020-10-18 Thread Kirti Wankhede
On 9/26/2020 2:32 AM, Alex Williamson wrote: On Wed, 23 Sep 2020 04:54:10 +0530 Kirti Wankhede wrote: Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy functions. These functions handles pre-copy and stop-and-copy phase. In _SAVING|_RUNNING device state or pre-co

Re: [PATCH v26 08/17] vfio: Add save state functions to SaveVMHandlers

2020-09-25 Thread Alex Williamson
On Wed, 23 Sep 2020 04:54:10 +0530 Kirti Wankhede wrote: > Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy > functions. These functions handles pre-copy and stop-and-copy phase. > > In _SAVING|_RUNNING device state or pre-copy phase: > - read pending_bytes. If pendin

RE: [PATCH v26 08/17] vfio: Add save state functions to SaveVMHandlers

2020-09-23 Thread Wang, Zhi A
I met a problem when trying this patch. Mostly the problem happens if a device doesn't set any pending bytes in the iteration stage, which shows this device doesn't have a stage of iteration. The QEMU in the destination machine will complain out-of-memory. After some investigation, it seems the