RE: [PATCH v2 05/10] net: cadence_gem: Set ISR according to queue in use

2020-05-06 Thread Sai Pavan Boddu
-...@nongnu.org; qemu- > de...@nongnu.org > Subject: Re: [PATCH v2 05/10] net: cadence_gem: Set ISR according to queue > in use > > On Mon, May 04, 2020 at 07:36:03PM +0530, Sai Pavan Boddu wrote: > > Set ISR according to queue in use, added interrupt support for all > > queues. &

Re: [PATCH v2 05/10] net: cadence_gem: Set ISR according to queue in use

2020-05-04 Thread Edgar E. Iglesias
On Mon, May 04, 2020 at 07:36:03PM +0530, Sai Pavan Boddu wrote: > Set ISR according to queue in use, added interrupt support for > all queues. Would it help to add a gem_set_isr(CadenceGEMState *s, int q, uint32_t flag) ? Instead of open coding these if (q == 0) else... all over the place... Any