Re: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Jason Gunthorpe
On Tue, May 16, 2023 at 02:35:21PM +, Shameerali Kolothum Thodi wrote: > Ok. Got it. So it depends on what SMMU does for that mapping and is not > related to migration per se and has the potential to crash the system if > SMMU go ahead with that memory access. Isn't it a more generic problem

RE: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Shameerali Kolothum Thodi via
kin ; > Cornelia Huck ; Paolo Bonzini > ; Vladimir Sementsov-Ogievskiy > ; Cédric Le Goater ; Yishai > Hadas ; Maor Gottlieb ; Kirti > Wankhede ; Tarun Gupta ; > Joao Martins > Subject: Re: [PATCH v11 05/11] vfio/migration: Block multiple devices > migration > > On Tu

Re: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Alex Williamson
> > Williamson ; Juan Quintela > > ; Dr. David Alan Gilbert ; > > Michael S. Tsirkin ; Cornelia Huck ; > > Paolo Bonzini ; Vladimir Sementsov-Ogievskiy > > ; Cédric Le Goater ; Yishai > > Hadas ; Maor Gottlieb ; Kirti > > Wankhede ; Tarun Gupta ; > > J

Re: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Jason Gunthorpe
On Tue, May 16, 2023 at 01:57:22PM +, Shameerali Kolothum Thodi wrote: > > What happens on your platform if a guest tries to do P2P? Does the > > platform crash? > > I am not sure. Since the devices are behind SMMU, I was under the assumption > that we do have the guarantee of isolation here(

RE: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Shameerali Kolothum Thodi via
Cornelia Huck ; > Paolo Bonzini ; Vladimir Sementsov-Ogievskiy > ; Cédric Le Goater ; Yishai > Hadas ; Maor Gottlieb ; Kirti > Wankhede ; Tarun Gupta ; > Joao Martins > Subject: Re: [PATCH v11 05/11] vfio/migration: Block multiple devices > migration > > On Tue, May 16,

Re: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Jason Gunthorpe
On Tue, May 16, 2023 at 10:03:54AM +, Shameerali Kolothum Thodi wrote: > > Currently VFIO migration doesn't implement some kind of intermediate > > quiescent state in which P2P DMAs are quiesced before stopping or > > running the device. This can cause problems in multi-device migration > > wh

RE: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: > qemu-devel-bounces+shameerali.kolothum.thodi=huawei@nongnu.org > [mailto:qemu-devel-bounces+shameerali.kolothum.thodi=huawei.com@nong > nu.org] On Behalf Of Avihai Horon > Sent: 16 February 2023 14:36 > To: qemu-devel@nongnu.org > Cc: Alex Williamson ; J