RE: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-27 Thread Shameerali Kolothum Thodi via
s ; Maor > Gottlieb ; Kirti Wankhede ; > Tarun Gupta ; qemu-devel@nongnu.org; Shameerali > Kolothum Thodi > Subject: Re: [PATCH 3/3] vfio/migration: Make VFIO migration > non-experimental > > On Tue, Jun 27, 2023 at 02:21:55PM +0200, Cédric Le Goater wrote: > > > We

Re: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-27 Thread Alex Williamson
On Tue, 27 Jun 2023 11:00:46 +0300 Avihai Horon wrote: > On 26/06/2023 20:27, Alex Williamson wrote: > > External email: Use caution opening links or attachments > > > > > > On Mon, 26 Jun 2023 17:26:42 +0200 > > Cédric Le Goater wrote: > > > >> On 6/26/23 15:40, Joao Martins wrote: > >>> On

Re: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-27 Thread Jason Gunthorpe
On Tue, Jun 27, 2023 at 02:21:55PM +0200, Cédric Le Goater wrote: > We have a way to run and migrate a machine with a device not supporting > dirty tracking. Only Hisilicon is in that case today. May be there are > plans to add dirty tracking support ? Hisilicon will eventually use Joao's work fo

Re: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-27 Thread Cédric Le Goater
[ Cc: Shameer ] I see ON_OFF_AUTO_ON as a way to abort the machine startup while ON_OFF_AUTO_AUTO would let it run but block migration. Agreed.  There's a little bit of redundancy between the device-level "enable-migration=on" option and the global "-only-migratable" option relative to preven

Re: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-27 Thread Avihai Horon
On 26/06/2023 20:27, Alex Williamson wrote: External email: Use caution opening links or attachments On Mon, 26 Jun 2023 17:26:42 +0200 Cédric Le Goater wrote: On 6/26/23 15:40, Joao Martins wrote: On 26/06/2023 14:20, Cédric Le Goater wrote: Hello Avihai, On 6/26/23 10:23, Avihai Horon

Re: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-26 Thread Alex Williamson
On Mon, 26 Jun 2023 17:26:42 +0200 Cédric Le Goater wrote: > On 6/26/23 15:40, Joao Martins wrote: > > On 26/06/2023 14:20, Cédric Le Goater wrote: > >> Hello Avihai, > >> > >> On 6/26/23 10:23, Avihai Horon wrote: > >>> The major parts of VFIO migration are supported today in QEMU. This > >>

Re: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-26 Thread Cédric Le Goater
On 6/26/23 18:19, Jason Gunthorpe wrote: On Mon, Jun 26, 2023 at 05:26:42PM +0200, Cédric Le Goater wrote: Since dirty tracking is a must-have to implement migration support for any existing and future VFIO PCI variant driver, anything else would be experimental code and we are trying to remove

Re: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-26 Thread Joao Martins
On 26/06/2023 16:26, Cédric Le Goater wrote: > On 6/26/23 15:40, Joao Martins wrote: >> On 26/06/2023 14:20, Cédric Le Goater wrote: >>> On 6/26/23 10:23, Avihai Horon wrote: +    error_setg(&vbasedev->migration_blocker, +   "%s: Migration couldn't be initialized for V

Re: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-26 Thread Jason Gunthorpe
On Mon, Jun 26, 2023 at 05:26:42PM +0200, Cédric Le Goater wrote: > Since dirty tracking is a must-have to implement migration support > for any existing and future VFIO PCI variant driver, anything else > would be experimental code and we are trying to remove the flag ! > Please correct me if I a

Re: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-26 Thread Cédric Le Goater
On 6/26/23 15:40, Joao Martins wrote: On 26/06/2023 14:20, Cédric Le Goater wrote: Hello Avihai, On 6/26/23 10:23, Avihai Horon wrote: The major parts of VFIO migration are supported today in QEMU. This includes basic VFIO migration, device dirty page tracking and precopy support. Thus, at th

Re: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-26 Thread Joao Martins
On 26/06/2023 14:20, Cédric Le Goater wrote: > Hello Avihai, > > On 6/26/23 10:23, Avihai Horon wrote: >> The major parts of VFIO migration are supported today in QEMU. This >> includes basic VFIO migration, device dirty page tracking and precopy >> support. >> >> Thus, at this point in time, it s

Re: [PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

2023-06-26 Thread Cédric Le Goater
Hello Avihai, On 6/26/23 10:23, Avihai Horon wrote: The major parts of VFIO migration are supported today in QEMU. This includes basic VFIO migration, device dirty page tracking and precopy support. Thus, at this point in time, it seems appropriate to make VFIO migration non-experimental: remov