Re: [PATCH 08/11] tcg/optimize: Remove redundant statement in tcg_optimize()

2020-08-17 Thread Richard Henderson
On 8/17/20 6:04 AM, Chenqun (kuhn) wrote: > Other branches(eg:' CASE_OP_32_64(brcond)') have changed the opc value too. > Do we need to assign a value to nb_iargs for it? In those cases nb_iargs does not change. r~

RE: [PATCH 08/11] tcg/optimize: Remove redundant statement in tcg_optimize()

2020-08-17 Thread Chenqun (kuhn)
> > diff --git a/tcg/optimize.c b/tcg/optimize.c index > > 53aa8e5329..d5bea37290 100644 > > --- a/tcg/optimize.c > > +++ b/tcg/optimize.c > > @@ -1264,7 +1264,6 @@ void tcg_optimize(TCGContext *s) > > op->opc = opc = (opc == INDEX_op_movcond_i32 > >

Re: [PATCH 08/11] tcg/optimize: Remove redundant statement in tcg_optimize()

2020-08-13 Thread Richard Henderson
On 8/13/20 12:37 AM, Chen Qun wrote: > Clang static code analyzer show warning: > tcg/optimize.c:1267:17: warning: Value stored to 'nb_iargs' is never read > nb_iargs = 2; > ^ ~ > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > Cc: Richard He