20.11.2023 18:04, Philippe Mathieu-Daudé:
Both cryptodev_backend_set_throttle() and CryptoDevBackendClass::init()
can set their Error** argument. Do not ignore them, return early on
failure. Use the ERRP_GUARD() macro as suggested in commit ae7c80a7bd
("error: New macro ERRP_GUARD()").
Cc: qemu-
Philippe Mathieu-Daudé writes:
> Both cryptodev_backend_set_throttle() and CryptoDevBackendClass::init()
> can set their Error** argument. Do not ignore them, return early on
> failure.
Let's mention why we need to: "Without that, running into another
failure trips error_setv()'s assertion."
>
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@linaro.org]
> Sent: Monday, November 20, 2023 11:04 PM
> To: qemu-devel@nongnu.org
> Cc: Zhenwei Pi ; Gonglei (Arei)
> ; Markus Armbruster ;
> Daniel P . Berrangé ; Philippe Mathieu-Daudé
> ; qemu-sta...@nongnu.org
> Subje
Looks good to me. Thanks!
Reviewed-by: zhenwei pi
On 11/20/23 23:04, Philippe Mathieu-Daudé wrote:
Both cryptodev_backend_set_throttle() and CryptoDevBackendClass::init()
can set their Error** argument. Do not ignore them, return early on
failure. Use the ERRP_GUARD() macro as suggested in com
