Re: QMP netdev_add multiple dnssearch values

2020-03-13 Thread Markus Armbruster
Eric Blake writes: > On 11/27/19 9:49 AM, Eric Blake wrote: >> On 11/27/19 7:30 AM, Markus Armbruster wrote: >> >>> "Good enough" was true back then.  It wasn't true when we reused it for >>> netdev_add: hostfwd and guestfwd are list-valued. >>> >>> We did define a QAPI schema a few months later

Re: QMP netdev_add multiple dnssearch values

2020-03-12 Thread Eric Blake
On 11/27/19 9:49 AM, Eric Blake wrote: On 11/27/19 7:30 AM, Markus Armbruster wrote: "Good enough" was true back then.  It wasn't true when we reused it for netdev_add: hostfwd and guestfwd are list-valued. We did define a QAPI schema a few months later (14aa0c2de0 "qapi schema: add Netdev typ

Re: QMP netdev_add multiple dnssearch values

2019-11-27 Thread Eric Blake
On 11/27/19 7:30 AM, Markus Armbruster wrote: "Good enough" was true back then. It wasn't true when we reused it for netdev_add: hostfwd and guestfwd are list-valued. We did define a QAPI schema a few months later (14aa0c2de0 "qapi schema: add Netdev types"). net_client_init() uses it to conv

Re: QMP netdev_add multiple dnssearch values

2019-11-27 Thread Markus Armbruster
Alex Kirillov writes: >> What exactly goes wrong? Does the QMP command fail? Does it succeed >> but the network backend incorrectly? > > QMP command succesfully creates Slirp backend, but ignore whole arguments: > - `dnssearch` > - `hostfwd` > - `guestfwd` You're right, QMP command netdev_add si

Re: QMP netdev_add multiple dnssearch values

2019-10-29 Thread Alex Kirillov
> What exactly goes wrong? Does the QMP command fail? Does it succeed > but the network backend incorrectly? QMP command succesfully creates Slirp backend, but ignore whole arguments: - `dnssearch` - `hostfwd` - `guestfwd` As example, `dnssearch` field of `NetdevUserOptions` goes straight to the

Re: QMP netdev_add multiple dnssearch values

2019-10-24 Thread Markus Armbruster
Alex Kirillov writes: > Hi, > > I'm trying to create a user (slirp) interface with several `dnssearch` values > using QMP. > But every variant I pass can't do that. What exactly goes wrong? Does the QMP command fail? Does it succeed but the network backend incorrectly? > According to the QAP

QMP netdev_add multiple dnssearch values

2019-10-17 Thread Alex Kirillov
Hi, I'm trying to create a user (slirp) interface with several `dnssearch` values using QMP. But every variant I pass can't do that. According to the QAPI schema it should be like: {     "execute": "netdev_add",     "arguments": {         "id": "netdev0",         "type": "user",         "dnssea