Re: QEMU tests, Coverity, and g_test_set_nonfatal_assertions()

2021-05-05 Thread Markus Armbruster
Peter Maydell writes: [...] > In summary, we have a few options: > > (1) Expand "assertions always fatal" to test code, and add "panics" > models of the g_assertion_message* functions. Remove all the calls > to g_test_set_nonfatal_assertions(). > > (2) Aim to expand the ability to use g_test_set

Re: QEMU tests, Coverity, and g_test_set_nonfatal_assertions()

2021-05-03 Thread Richard Henderson
On 5/3/21 9:49 AM, Peter Maydell wrote: (1) Expand "assertions always fatal" to test code, and add "panics" models of the g_assertion_message* functions. Remove all the calls to g_test_set_nonfatal_assertions(). I vaguely prefer this. To me, "assert" means can't continue. If we want tests tha

Re: QEMU tests, Coverity, and g_test_set_nonfatal_assertions()

2021-05-03 Thread Peter Maydell
On Mon, 3 May 2021 at 18:15, Richard Henderson wrote: > > On 5/3/21 9:49 AM, Peter Maydell wrote: > > (1) Expand "assertions always fatal" to test code, and add "panics" > > models of the g_assertion_message* functions. Remove all the calls > > to g_test_set_nonfatal_assertions(). > > I vaguely pr

QEMU tests, Coverity, and g_test_set_nonfatal_assertions()

2021-05-03 Thread Peter Maydell
Currently we generally assume that assertions are always present and always fatal, and we tell Coverity this by putting this into our model file: void g_assertion_message_expr(const char *domain, const char *file, int