> I have been testing TCG plugin patch on latest Qemu build but noticed that it
> fails with assert on some of the applications.
>
>ERROR:../accel/tcg/cpu-exec.c:983:cpu_exec_loop:
>assertion failed: (cpu->plugin_mem_cbs == ((void *)0))
>
It seems that the problem is around tcg_ctx->
Hello,
I have been testing TCG plugin patch on latest Qemu build but noticed that it
fails with assert on some of the applications.
ERROR:../accel/tcg/cpu-exec.c:983:cpu_exec_loop:
assertion failed: (cpu->plugin_mem_cbs == ((void *)0))
It happens when TCG plugin sets memory callb
On Fri, Jan 6, 2023, 5:31 AM Alex Bennée wrote:
> Are you going to be able to post the patches soon? I'd like to get the
> fixes in as early in the cycle as possible.
>
I intend to post this series on Sunday.
Thanks,
Emilio
Aaron Lindsay writes:
> Emilio,
>
> On Dec 18 00:24, Emilio Cota wrote:
>> On Tue, Nov 29, 2022 at 15:37:51 -0500, Aaron Lindsay wrote:
>> (snip)
>> > > Does this hint that there are cases where reset cpu->plugin_mem_cbs to
>> > > NULL is
>> > > getting optimized away, but not the code to set
Emilio,
On Dec 18 00:24, Emilio Cota wrote:
> On Tue, Nov 29, 2022 at 15:37:51 -0500, Aaron Lindsay wrote:
> (snip)
> > > Does this hint that there are cases where reset cpu->plugin_mem_cbs to
> > > NULL is
> > > getting optimized away, but not the code to set it in the first place?
> >
> > Is t
On Tue, Nov 29, 2022 at 15:37:51 -0500, Aaron Lindsay wrote:
(snip)
> > Does this hint that there are cases where reset cpu->plugin_mem_cbs to NULL
> > is
> > getting optimized away, but not the code to set it in the first place?
>
> Is there anyone who could help take a look at this from the cod
Aaron Lindsay writes:
> On Nov 22 10:57, Aaron Lindsay wrote:
>> On Nov 21 18:22, Richard Henderson wrote:
>> > On 11/21/22 13:51, Alex Bennée wrote:
>> > >
>> > > Aaron Lindsay writes:
>> > >
>> > > > On Nov 15 22:36, Alex Bennée wrote:
>> > > > > Aaron Lindsay writes:
>> > > > > > I belie
On Nov 22 10:57, Aaron Lindsay wrote:
> On Nov 21 18:22, Richard Henderson wrote:
> > On 11/21/22 13:51, Alex Bennée wrote:
> > >
> > > Aaron Lindsay writes:
> > >
> > > > On Nov 15 22:36, Alex Bennée wrote:
> > > > > Aaron Lindsay writes:
> > > > > > I believe the code *should* always reset `c
On Nov 21 22:02, Alex Bennée wrote:
>
> Aaron Lindsay writes:
>
> > Sorry, left off the very end of my timeline:
> >
> > On Nov 18 16:58, Aaron Lindsay wrote:
> >> I have, so far, discovered the following timeline:
> >> 1. My plugin receives a instruction execution callback for a load
> >>in
On Nov 21 18:22, Richard Henderson wrote:
> On 11/21/22 13:51, Alex Bennée wrote:
> >
> > Aaron Lindsay writes:
> >
> > > On Nov 15 22:36, Alex Bennée wrote:
> > > > Aaron Lindsay writes:
> > > > > I believe the code *should* always reset `cpu->plugin_mem_cbs` to
> > > > > NULL at the
> > > >
On 11/21/22 13:51, Alex Bennée wrote:
Aaron Lindsay writes:
On Nov 15 22:36, Alex Bennée wrote:
Aaron Lindsay writes:
I believe the code *should* always reset `cpu->plugin_mem_cbs` to NULL at the
end of an instruction/TB's execution, so its not exactly clear to me how this
is occurring. Ho
Aaron Lindsay writes:
> Sorry, left off the very end of my timeline:
>
> On Nov 18 16:58, Aaron Lindsay wrote:
>> I have, so far, discovered the following timeline:
>> 1. My plugin receives a instruction execution callback for a load
>>instruction. At this time, cpu->plugin_mem_cbs points t
Aaron Lindsay writes:
> On Nov 15 22:36, Alex Bennée wrote:
>> Aaron Lindsay writes:
>> > I believe the code *should* always reset `cpu->plugin_mem_cbs` to NULL at
>> > the
>> > end of an instruction/TB's execution, so its not exactly clear to me how
>> > this
>> > is occurring. However, I s
On Nov 15 22:36, Alex Bennée wrote:
> Aaron Lindsay writes:
> > I believe the code *should* always reset `cpu->plugin_mem_cbs` to NULL at
> > the
> > end of an instruction/TB's execution, so its not exactly clear to me how
> > this
> > is occurring. However, I suspect it may be relevant that we
On Nov 15 22:36, Alex Bennée wrote:
>
> Aaron Lindsay writes:
>
> > Hello,
> >
> > I have been wrestling with what might be a bug in the plugin memory
> > callbacks. The immediate error is that I hit the
> > `g_assert_not_reached()` in the 'default:' case in
> > qemu_plugin_vcpu_mem_cb, indicati
Sorry, left off the very end of my timeline:
On Nov 18 16:58, Aaron Lindsay wrote:
> I have, so far, discovered the following timeline:
> 1. My plugin receives a instruction execution callback for a load
>instruction. At this time, cpu->plugin_mem_cbs points to the same
>memory which will
On Tue, Nov 15, 2022 at 22:36:07 +, Alex Bennée wrote:
> This is exactly the sort of thing rr is great for. Can you trigger it in
> that?
>
> https://rr-project.org/
The sanitizers should also help.
For TLB flush tracing, defining DEBUG_TLB at the top of cputlb.c
might be useful.
Aaron Lindsay writes:
> Hello,
>
> I have been wrestling with what might be a bug in the plugin memory
> callbacks. The immediate error is that I hit the
> `g_assert_not_reached()` in the 'default:' case in
> qemu_plugin_vcpu_mem_cb, indicating the callback type was invalid. When
> breaking on
Hello,
I have been wrestling with what might be a bug in the plugin memory
callbacks. The immediate error is that I hit the
`g_assert_not_reached()` in the 'default:' case in
qemu_plugin_vcpu_mem_cb, indicating the callback type was invalid. When
breaking on this assertion in gdb, the contents of
This test makes sure that the inline and callback based memory checks
count the same number of accesses.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210213130325.14781-24-alex.ben...@linaro.org>
diff --git a/tests/acceptance/tcg_plugins.py b/tests/acceptance/tc
On 2/13/21 2:03 PM, Alex Bennée wrote:
> This test makes sure that the inline and callback based memory checks
> count the same number of accesses.
>
> Signed-off-by: Alex Bennée
> ---
> tests/acceptance/tcg_plugins.py | 31 +++
> 1 file changed, 31 insertions(+)
Rev
This test makes sure that the inline and callback based memory checks
count the same number of accesses.
Signed-off-by: Alex Bennée
---
tests/acceptance/tcg_plugins.py | 31 +++
1 file changed, 31 insertions(+)
diff --git a/tests/acceptance/tcg_plugins.py b/tests/acc
Sorry to bother you, I would like to ask a question.I want to use qemu to
monitor the information of the target thread reading and writing memory. I
see that qemu supports the tcg plugin, but I just find the following code
in plugin-gen.c .Do I just need to add a record function in it? How do I
rea
23 matches
Mail list logo