Re: Bad error handling in loongarch's kvm_arch_init_vcpu(), need advice

2025-03-15 Thread Paolo Bonzini
On 3/12/25 09:39, Markus Armbruster wrote: scripts/coccinelle/error-use-after-free.cocci led me to target/loongarch/kvm/kvm.c: ret = kvm_cpu_check_lsx(cs, &local_err); if (ret < 0) { error_report_err(local_err); Reporting an error, but continue anyway. This is su

Re: Bad error handling in loongarch's kvm_arch_init_vcpu(), need advice

2025-03-12 Thread bibo mao
On 2025/3/12 下午4:59, Paolo Bonzini wrote: On 3/12/25 09:39, Markus Armbruster wrote: scripts/coccinelle/error-use-after-free.cocci led me to target/loongarch/kvm/kvm.c: ret = kvm_cpu_check_lsx(cs, &local_err); if (ret < 0) { error_report_err(local_err); Report

Bad error handling in loongarch's kvm_arch_init_vcpu(), need advice

2025-03-12 Thread Markus Armbruster
scripts/coccinelle/error-use-after-free.cocci led me to target/loongarch/kvm/kvm.c: int kvm_arch_init_vcpu(CPUState *cs) { uint64_t val; int ret; Error *local_err = NULL; ret = 0; qemu_add_vm_change_state_handler(kvm_loongarch_vm_stage_change, cs);