Re: [PATCH RESEND v3 06/10] block: Support detached LUKS header creation using blockdev-create

2024-01-11 Thread Yong Huang
On Thu, Jan 11, 2024 at 10:05 PM Markus Armbruster wrote: > Fails to compile for me: > > ../block/crypto.c: In function ‘block_crypto_co_create_luks’: > ../block/crypto.c:784:1: error: control reaches end of non-void function > [-Werror=return-type] > 784 | } > | ^ > > Ok, I'll check it o

Re: [PATCH RESEND v3 06/10] block: Support detached LUKS header creation using blockdev-create

2024-01-11 Thread Markus Armbruster
Fails to compile for me: ../block/crypto.c: In function ‘block_crypto_co_create_luks’: ../block/crypto.c:784:1: error: control reaches end of non-void function [-Werror=return-type] 784 | } | ^

Re: [PATCH RESEND v3 06/10] block: Support detached LUKS header creation using blockdev-create

2024-01-04 Thread Daniel P . Berrangé
On Mon, Dec 25, 2023 at 01:45:08PM +0800, Hyman Huang wrote: > The LUKS disk with detached header consists of a separate LUKS > header and payload. This LUKS disk type should be formatted > as follows: > > 1. add the secret to lock/unlock the cipher stored in the >detached LUKS header > $ virs

[PATCH RESEND v3 06/10] block: Support detached LUKS header creation using blockdev-create

2023-12-24 Thread Hyman Huang
The LUKS disk with detached header consists of a separate LUKS header and payload. This LUKS disk type should be formatted as follows: 1. add the secret to lock/unlock the cipher stored in the detached LUKS header $ virsh qemu-monitor-command vm '{"execute":"object-add", > "arguments":{"qom-typ

[v3 06/10] block: Support detached LUKS header creation using blockdev-create

2023-12-24 Thread Hyman Huang
The LUKS disk with detached header consists of a separate LUKS header and payload. This LUKS disk type should be formatted as follows: 1. add the secret to lock/unlock the cipher stored in the detached LUKS header $ virsh qemu-monitor-command vm '{"execute":"object-add", > "arguments":{"qom-typ