Re: [PATCH RESEND v3 03/10] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-01-04 Thread Daniel P . Berrangé
On Mon, Dec 25, 2023 at 01:45:05PM +0800, Hyman Huang wrote: > To support detached LUKS header creation, make the existing 'file' > filed in BlockdevCreateOptionsLUKS optional, while also adding an > extra optional 'header' field in the next commit. > > Signed-off-by: Hyman Huang > --- > block/c

[PATCH RESEND v3 03/10] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2023-12-24 Thread Hyman Huang
To support detached LUKS header creation, make the existing 'file' filed in BlockdevCreateOptionsLUKS optional, while also adding an extra optional 'header' field in the next commit. Signed-off-by: Hyman Huang --- block/crypto.c | 21 ++--- qapi/block-core.json | 5 +++--

[v3 03/10] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2023-12-24 Thread Hyman Huang
To support detached LUKS header creation, make the existing 'file' filed in BlockdevCreateOptionsLUKS optional, while also adding an extra optional 'header' field in the next commit. Signed-off-by: Hyman Huang --- block/crypto.c | 21 ++--- qapi/block-core.json | 5 +++--