Re: [Virtio-fs] [PATCH 3/3] virtiofsd: Don't allow empty filenames

2021-03-15 Thread Vivek Goyal
On Mon, Mar 15, 2021 at 11:06:30AM +0100, Greg Kurz wrote: > On Sun, 14 Mar 2021 19:36:04 -0400 > Vivek Goyal wrote: > > > On Fri, Mar 12, 2021 at 03:10:03PM +0100, Greg Kurz wrote: > > > POSIX.1-2017 clearly stipulates that empty filenames aren't > > > allowed ([1] and [2]). Since virtiofsd is s

Re: [Virtio-fs] [PATCH 3/3] virtiofsd: Don't allow empty filenames

2021-03-15 Thread Greg Kurz
On Mon, 15 Mar 2021 15:18:48 + "Dr. David Alan Gilbert" wrote: > * Greg Kurz (gr...@kaod.org) wrote: > > On Sun, 14 Mar 2021 19:36:04 -0400 > > Vivek Goyal wrote: > > > > > On Fri, Mar 12, 2021 at 03:10:03PM +0100, Greg Kurz wrote: > > > > POSIX.1-2017 clearly stipulates that empty filename

Re: [Virtio-fs] [PATCH 3/3] virtiofsd: Don't allow empty filenames

2021-03-15 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > On Sun, 14 Mar 2021 19:36:04 -0400 > Vivek Goyal wrote: > > > On Fri, Mar 12, 2021 at 03:10:03PM +0100, Greg Kurz wrote: > > > POSIX.1-2017 clearly stipulates that empty filenames aren't > > > allowed ([1] and [2]). Since virtiofsd is supposed to mirror > > >

Re: [Virtio-fs] [PATCH 3/3] virtiofsd: Don't allow empty filenames

2021-03-15 Thread Greg Kurz
On Sun, 14 Mar 2021 19:36:04 -0400 Vivek Goyal wrote: > On Fri, Mar 12, 2021 at 03:10:03PM +0100, Greg Kurz wrote: > > POSIX.1-2017 clearly stipulates that empty filenames aren't > > allowed ([1] and [2]). Since virtiofsd is supposed to mirror > > the host file system hierarchy and the host can b

Re: [Virtio-fs] [PATCH 3/3] virtiofsd: Don't allow empty filenames

2021-03-14 Thread Vivek Goyal
On Fri, Mar 12, 2021 at 03:10:03PM +0100, Greg Kurz wrote: > POSIX.1-2017 clearly stipulates that empty filenames aren't > allowed ([1] and [2]). Since virtiofsd is supposed to mirror > the host file system hierarchy and the host can be assumed to > be linux, we don't really expect clients to pass

Re: [Virtio-fs] [PATCH 3/3] virtiofsd: Don't allow empty filenames

2021-03-12 Thread Connor Kuehl
On 3/12/21 8:10 AM, Greg Kurz wrote: POSIX.1-2017 clearly stipulates that empty filenames aren't allowed ([1] and [2]). Since virtiofsd is supposed to mirror the host file system hierarchy and the host can be assumed to be linux, we don't really expect clients to pass requests with an empty path