Re: [RISU v2 14/17] Add magic and size to the trace header

2020-05-20 Thread Alex Bennée
Richard Henderson writes: > On 5/18/20 7:53 PM, Richard Henderson wrote: >> +if (master_header.magic != RISU_MAGIC || >> +master_header.risu_op != op || >> +master_header.size != extra_size) { >> +res = RES_MISMATCH_HEAD; >> +goto fail_header; >> } > > H

Re: [RISU v2 14/17] Add magic and size to the trace header

2020-05-19 Thread Richard Henderson
On 5/18/20 7:53 PM, Richard Henderson wrote: > +if (master_header.magic != RISU_MAGIC || > +master_header.risu_op != op || > +master_header.size != extra_size) { > +res = RES_MISMATCH_HEAD; > +goto fail_header; > } Hmm. This isn't ideal. Consider e.g. an

[RISU v2 14/17] Add magic and size to the trace header

2020-05-18 Thread Richard Henderson
Sanity check that we're not getting out of sync with the trace stream. This will be especially bad with the change in size of the sve save data. Signed-off-by: Richard Henderson --- risu.h| 8 ++- reginfo.c | 160 -- risu.c| 6 ++