Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-09-01 Thread Jason Wang
On 2020/9/2 上午3:35, Peter Xu wrote: On Tue, Sep 01, 2020 at 11:05:18AM +0800, Jason Wang wrote: On 2020/8/21 下午10:12, Peter Xu wrote: On Thu, Aug 20, 2020 at 10:28:00AM +0800, Jason Wang wrote: On 2020/8/19 下午11:50, Peter Xu wrote: On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote:

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-09-01 Thread Peter Xu
On Tue, Sep 01, 2020 at 11:05:18AM +0800, Jason Wang wrote: > > On 2020/8/21 下午10:12, Peter Xu wrote: > > On Thu, Aug 20, 2020 at 10:28:00AM +0800, Jason Wang wrote: > > > On 2020/8/19 下午11:50, Peter Xu wrote: > > > > On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote: > > > > > Yes, actua

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-31 Thread Jason Wang
On 2020/8/21 下午10:12, Peter Xu wrote: On Thu, Aug 20, 2020 at 10:28:00AM +0800, Jason Wang wrote: On 2020/8/19 下午11:50, Peter Xu wrote: On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote: Yes, actually, I feel confused after reading the codes. Is notifier->start IOVA or GPA? In vfio

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-21 Thread Peter Xu
On Thu, Aug 20, 2020 at 10:28:00AM +0800, Jason Wang wrote: > > On 2020/8/19 下午11:50, Peter Xu wrote: > > On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote: > > > Yes, actually, I feel confused after reading the codes. Is notifier->start > > > IOVA or GPA? > > > > > > In vfio.c, we did:

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-19 Thread Jason Wang
On 2020/8/19 下午11:50, Peter Xu wrote: On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote: Yes, actually, I feel confused after reading the codes. Is notifier->start IOVA or GPA? In vfio.c, we did:     iommu_notifier_init(&giommu->n, vfio_iommu_map_notify,   

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-19 Thread Peter Xu
On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote: > Yes, actually, I feel confused after reading the codes. Is notifier->start > IOVA or GPA? > > In vfio.c, we did: > >     iommu_notifier_init(&giommu->n, vfio_iommu_map_notify, >     IOMMU_NOTIFIER_ALL, >    

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-19 Thread Jason Wang
On 2020/8/19 下午4:22, Eugenio Perez Martin wrote: On Wed, Aug 19, 2020 at 9:15 AM Jason Wang wrote: On 2020/8/18 下午10:24, Eugenio Perez Martin wrote: On Wed, Aug 12, 2020 at 10:49 AM Eugenio Perez Martin wrote: On Wed, Aug 12, 2020 at 4:24 AM Jason Wang wrote: On 2020/8/12 上午1:55, Eugen

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-19 Thread Eugenio Perez Martin
On Wed, Aug 19, 2020 at 9:15 AM Jason Wang wrote: > > > On 2020/8/18 下午10:24, Eugenio Perez Martin wrote: > > On Wed, Aug 12, 2020 at 10:49 AM Eugenio Perez Martin > > wrote: > >> On Wed, Aug 12, 2020 at 4:24 AM Jason Wang wrote: > >>> On 2020/8/12 上午1:55, Eugenio Pérez wrote: > Signed-off

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-19 Thread Jason Wang
On 2020/8/18 下午10:24, Eugenio Perez Martin wrote: On Wed, Aug 12, 2020 at 10:49 AM Eugenio Perez Martin wrote: On Wed, Aug 12, 2020 at 4:24 AM Jason Wang wrote: On 2020/8/12 上午1:55, Eugenio Pérez wrote: Signed-off-by: Eugenio Pérez --- hw/virtio/vhost.c | 2 +- include/exec/memo

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-18 Thread Eugenio Perez Martin
On Wed, Aug 12, 2020 at 10:49 AM Eugenio Perez Martin wrote: > > On Wed, Aug 12, 2020 at 4:24 AM Jason Wang wrote: > > > > > > On 2020/8/12 上午1:55, Eugenio Pérez wrote: > > > Signed-off-by: Eugenio Pérez > > > --- > > > hw/virtio/vhost.c | 2 +- > > > include/exec/memory.h | 2 ++ > > >

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-12 Thread Eugenio Perez Martin
On Wed, Aug 12, 2020 at 4:24 AM Jason Wang wrote: > > > On 2020/8/12 上午1:55, Eugenio Pérez wrote: > > Signed-off-by: Eugenio Pérez > > --- > > hw/virtio/vhost.c | 2 +- > > include/exec/memory.h | 2 ++ > > softmmu/memory.c | 10 -- > > 3 files changed, 11 insertions(+), 3

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-11 Thread Jason Wang
On 2020/8/12 上午1:55, Eugenio Pérez wrote: Signed-off-by: Eugenio Pérez --- hw/virtio/vhost.c | 2 +- include/exec/memory.h | 2 ++ softmmu/memory.c | 10 -- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 1a138

[RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-11 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/virtio/vhost.c | 2 +- include/exec/memory.h | 2 ++ softmmu/memory.c | 10 -- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 1a1384e7a6..e74ad9e09b 100644 --- a/hw/virtio/vhost.c +