Re: [RFC v3 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-12 Thread Peter Xu
On Wed, Aug 12, 2020 at 04:33:24PM +0200, Eugenio Perez Martin wrote: > On Tue, Aug 11, 2020 at 9:28 PM Peter Xu wrote: > > > > Hi, Eugenio, > > > > On Tue, Aug 11, 2020 at 08:10:44PM +0200, Eugenio Perez Martin wrote: > > > Using this patch as a reference, I'm having problems to understand: > > >

Re: [RFC v3 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-12 Thread Eugenio Perez Martin
On Tue, Aug 11, 2020 at 9:28 PM Peter Xu wrote: > > Hi, Eugenio, > > On Tue, Aug 11, 2020 at 08:10:44PM +0200, Eugenio Perez Martin wrote: > > Using this patch as a reference, I'm having problems to understand: > > > > - I'm not sure that the flag name expresses clearly the notifier capability. >

Re: [RFC v3 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-11 Thread Peter Xu
Hi, Eugenio, On Tue, Aug 11, 2020 at 08:10:44PM +0200, Eugenio Perez Martin wrote: > Using this patch as a reference, I'm having problems to understand: > > - I'm not sure that the flag name expresses clearly the notifier capability. The old code is kind of messed up for dev-iotlb invalidations,

Re: [RFC v3 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-11 Thread Eugenio Perez Martin
On Tue, Aug 11, 2020 at 7:56 PM Eugenio Pérez wrote: > > I am able to hit this assertion when a Red Hat 7 guest virtio_net device > raises an "Invalidation" of all the TLB entries. This happens in the > guest's startup if 'intel_iommu=on' argument is passed to the guest > kernel and right IOMMU/AT

[RFC v3 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-11 Thread Eugenio Pérez
I am able to hit this assertion when a Red Hat 7 guest virtio_net device raises an "Invalidation" of all the TLB entries. This happens in the guest's startup if 'intel_iommu=on' argument is passed to the guest kernel and right IOMMU/ATS devices are declared in qemu's command line. Command line: /h