Re: [RFC v12 62/65] target/arm: refactor arm_cpu_finalize_features into cpu64

2021-04-13 Thread Claudio Fontana
On 3/28/21 9:15 PM, Richard Henderson wrote: > On 3/28/21 1:12 PM, Richard Henderson wrote: >> On 3/26/21 1:36 PM, Claudio Fontana wrote: >>> +++ b/target/arm/monitor.c >>> @@ -184,9 +184,11 @@ CpuModelExpansionInfo >>> *qmp_query_cpu_model_expansion(CpuModelExpansionType type, >>>   if (!

Re: [RFC v12 62/65] target/arm: refactor arm_cpu_finalize_features into cpu64

2021-03-28 Thread Richard Henderson
On 3/28/21 1:12 PM, Richard Henderson wrote: On 3/26/21 1:36 PM, Claudio Fontana wrote: +++ b/target/arm/monitor.c @@ -184,9 +184,11 @@ CpuModelExpansionInfo *qmp_query_cpu_model_expansion(CpuModelExpansionType type,   if (!err) {   visit_check_struct(visitor, &err);   

Re: [RFC v12 62/65] target/arm: refactor arm_cpu_finalize_features into cpu64

2021-03-28 Thread Richard Henderson
On 3/26/21 1:36 PM, Claudio Fontana wrote: +++ b/target/arm/monitor.c @@ -184,9 +184,11 @@ CpuModelExpansionInfo *qmp_query_cpu_model_expansion(CpuModelExpansionType type, if (!err) { visit_check_struct(visitor, &err); } +#ifdef TARGET_AARCH64 if (!err

[RFC v12 62/65] target/arm: refactor arm_cpu_finalize_features into cpu64

2021-03-26 Thread Claudio Fontana
all the features in arm_cpu_finalize_features are actually TARGET_AARCH64-only, since KVM is now only supported on 64bit. Therefore move the function to cpu64, and rename it to aarch64_cpu_finalize_features. Signed-off-by: Claudio Fontana --- target/arm/cpu.h | 3 +- target/arm/kvm/kvm