Re: [RFC for-6.2] block/nbd: forbid incompatible change of server options on reconnect

2021-11-29 Thread Vladimir Sementsov-Ogievskiy
29.11.2021 22:16, Eric Blake wrote: On Wed, Nov 24, 2021 at 03:09:51PM +0100, Vladimir Sementsov-Ogievskiy wrote: Reconnect feature was never prepared to handle server options changed on reconnect. Let's be stricter and check what exactly is changed. If server capabilities just got richer don't

Re: [RFC for-6.2] block/nbd: forbid incompatible change of server options on reconnect

2021-11-29 Thread Vladimir Sementsov-Ogievskiy
29.11.2021 20:34, Eric Blake wrote: On Wed, Nov 24, 2021 at 03:09:51PM +0100, Vladimir Sementsov-Ogievskiy wrote: Reconnect feature was never prepared to handle server options changed on reconnect. Let's be stricter and check what exactly is changed. If server capabilities just got richer don't

Re: [RFC for-6.2] block/nbd: forbid incompatible change of server options on reconnect

2021-11-29 Thread Eric Blake
On Wed, Nov 24, 2021 at 03:09:51PM +0100, Vladimir Sementsov-Ogievskiy wrote: > Reconnect feature was never prepared to handle server options changed > on reconnect. Let's be stricter and check what exactly is changed. If > server capabilities just got richer don't worry. Otherwise fail and > drop

Re: [RFC for-6.2] block/nbd: forbid incompatible change of server options on reconnect

2021-11-29 Thread Eric Blake
On Wed, Nov 24, 2021 at 03:09:51PM +0100, Vladimir Sementsov-Ogievskiy wrote: > Reconnect feature was never prepared to handle server options changed > on reconnect. Let's be stricter and check what exactly is changed. If > server capabilities just got richer don't worry. Otherwise fail and > drop

[RFC for-6.2] block/nbd: forbid incompatible change of server options on reconnect

2021-11-24 Thread Vladimir Sementsov-Ogievskiy
Reconnect feature was never prepared to handle server options changed on reconnect. Let's be stricter and check what exactly is changed. If server capabilities just got richer don't worry. Otherwise fail and drop the established connection. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all!