Re: [RFC PATCH v9 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-22 Thread Peter Maydell
On Fri, 22 Mar 2024 at 03:56, Jinjie Ruan wrote: > > > > On 2024/3/21 23:46, Peter Maydell wrote: > > Something somewhere needs to implement "if SCTLR_ELx.NMI is 0 then > > we don't take EXCP_VINMI etc but instead (maybe) EXCP_VIRQ etc". > > At the moment nothing does that: > > * arm_cpu_update_v

Re: [RFC PATCH v9 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-22 Thread Peter Maydell
On Fri, 22 Mar 2024 at 05:05, Jinjie Ruan wrote: > > > > On 2024/3/22 2:28, Peter Maydell wrote: > > On Thu, 21 Mar 2024 at 15:46, Peter Maydell > > wrote: > >> Something somewhere needs to implement "if SCTLR_ELx.NMI is 0 then > >> we don't take EXCP_VINMI etc but instead (maybe) EXCP_VIRQ etc"

Re: [RFC PATCH v9 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-21 Thread Jinjie Ruan via
On 2024/3/22 2:28, Peter Maydell wrote: > On Thu, 21 Mar 2024 at 15:46, Peter Maydell wrote: >> Something somewhere needs to implement "if SCTLR_ELx.NMI is 0 then >> we don't take EXCP_VINMI etc but instead (maybe) EXCP_VIRQ etc". >> At the moment nothing does that: >> * arm_cpu_update_vinmi()

Re: [RFC PATCH v9 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-21 Thread Jinjie Ruan via
On 2024/3/21 23:46, Peter Maydell wrote: > On Thu, 21 Mar 2024 at 13:10, Jinjie Ruan wrote: >> >> This only implements the external delivery method via the GICv3. >> >> Signed-off-by: Jinjie Ruan >> Reviewed-by: Richard Henderson >> --- >> v9: >> - Update the GPIOs passed in the arm_cpu_kvm_s

Re: [RFC PATCH v9 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-21 Thread Peter Maydell
On Thu, 21 Mar 2024 at 15:46, Peter Maydell wrote: > Something somewhere needs to implement "if SCTLR_ELx.NMI is 0 then > we don't take EXCP_VINMI etc but instead (maybe) EXCP_VIRQ etc". > At the moment nothing does that: > * arm_cpu_update_vinmi() doesn't look at the NMI bit before >deciding

Re: [RFC PATCH v9 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-21 Thread Peter Maydell
On Thu, 21 Mar 2024 at 13:10, Jinjie Ruan wrote: > > This only implements the external delivery method via the GICv3. > > Signed-off-by: Jinjie Ruan > Reviewed-by: Richard Henderson > --- > v9: > - Update the GPIOs passed in the arm_cpu_kvm_set_irq, and update the comment. > - Definitely not mer

[RFC PATCH v9 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-21 Thread Jinjie Ruan via
This only implements the external delivery method via the GICv3. Signed-off-by: Jinjie Ruan Reviewed-by: Richard Henderson --- v9: - Update the GPIOs passed in the arm_cpu_kvm_set_irq, and update the comment. - Definitely not merge VINMI and VFNMI into EXCP_VNMI. - Update VINMI and VFNMI when wr