Re: [RFC PATCH v4 2/4] Adding basic custom/vendor CSR handling mechanism

2021-08-12 Thread Alistair Francis
On Fri, Aug 6, 2021 at 3:58 AM Ruinland Chuan-Tzu Tsai wrote: > > From: Ruinalnd ChuanTzu Tsai > > For now we add a custom CSR handling mechanism to handle non-standard CSR read > or write. > > The write_stub() and read_zero() are provided for quick placeholder usage if > such CSRs' behavior are

Re: [RFC PATCH v4 2/4] Adding basic custom/vendor CSR handling mechanism

2021-08-05 Thread Bin Meng
On Fri, Aug 6, 2021 at 2:08 PM Ruinland Chuan-Tzu Tsa(蔡傳資) wrote: > > > Hi Bin and Alistair, > > > >> +#if defined(CONFIG_RISCV_CUSTOM) > >> +static void setup_custom_csr(CPURISCVState *env, > >> + riscv_custom_csr_operations csr_map_struct[] > >> +

Re: [RFC PATCH v4 2/4] Adding basic custom/vendor CSR handling mechanism

2021-08-05 Thread 蔡傳資
Hi Bin and Alistair, >> +#if defined(CONFIG_RISCV_CUSTOM) >> +static void setup_custom_csr(CPURISCVState *env, >> + riscv_custom_csr_operations csr_map_struct[] >> + ) { >{ should be put to the next line, per QEMU coding convention. Please

Re: [RFC PATCH v4 2/4] Adding basic custom/vendor CSR handling mechanism

2021-08-05 Thread Bin Meng
+Alistair On Fri, Aug 6, 2021 at 1:58 AM Ruinland Chuan-Tzu Tsai wrote: > > From: Ruinalnd ChuanTzu Tsai > > For now we add a custom CSR handling mechanism to handle non-standard CSR read > or write. > > The write_stub() and read_zero() are provided for quick placeholder usage if > such CSRs' be

[RFC PATCH v4 2/4] Adding basic custom/vendor CSR handling mechanism

2021-08-05 Thread Ruinland Chuan-Tzu Tsai
From: Ruinalnd ChuanTzu Tsai For now we add a custom CSR handling mechanism to handle non-standard CSR read or write. The write_stub() and read_zero() are provided for quick placeholder usage if such CSRs' behavior are expected to fail-over in its user code. Signed-off-by: Dylan Jhong --- tar