Re: [RFC PATCH v3 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2020-09-25 Thread Gerd Hoffmann
On Thu, Sep 24, 2020 at 01:04:19PM +0200, Igor Mammedov wrote: > On Thu, 24 Sep 2020 09:00:08 +0200 > Julia Suvorova wrote: > > > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. > > Gerd, > > does picked IO range loo

Re: [RFC PATCH v3 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2020-09-24 Thread Julia Suvorova
On Thu, Sep 24, 2020 at 3:15 PM Ani Sinha wrote: > > > > On Thu, 24 Sep 2020, Julia Suvorova wrote: > > > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. > > > > For this patch, I would suggest maybe you can also add a

Re: [RFC PATCH v3 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2020-09-24 Thread Ani Sinha
On Thu, 24 Sep 2020, Julia Suvorova wrote: Implement notifications and gpe to support q35 ACPI PCI hot-plug. Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. For this patch, I would suggest maybe you can also add a diff of the disassembly of the DSDT table so that we know what chan

Re: [RFC PATCH v3 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2020-09-24 Thread Igor Mammedov
On Thu, 24 Sep 2020 09:00:08 +0200 Julia Suvorova wrote: > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. Gerd, does picked IO range looks acceptable to you? > Signed-off-by: Julia Suvorova with minor nits below fi

[RFC PATCH v3 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2020-09-24 Thread Julia Suvorova
Implement notifications and gpe to support q35 ACPI PCI hot-plug. Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. Signed-off-by: Julia Suvorova --- hw/i386/acpi-build.h| 4 include/hw/acpi/ich9.h | 2 ++ include/hw/acpi/pcihp.h | 3 ++- hw/acpi/pcihp.c | 8