On 4/22/25 11:24, Markus Armbruster wrote:
Effectively duplicates generated enum SysEmuTarget. Can you explain why
that's useful?
In terms of code, it doesn't change anything. we could reuse SysEmuTarget.
I just think it's more clear to have the enum defined next to the structure
using it, co
Pierrick Bouvier writes:
> On 4/21/25 23:04, Markus Armbruster wrote:
>> Pierrick Bouvier writes:
>> [...]
>>
>>> At this point, I would like to focus on having a first version of
>>> TargetInfo API, and not reviewing any other changes, as things may be
>>> modified, and they would need to be
On 4/21/25 23:04, Markus Armbruster wrote:
Pierrick Bouvier writes:
[...]
At this point, I would like to focus on having a first version of TargetInfo
API, and not reviewing any other changes, as things may be modified, and they
would need to be reviewed again. It's hard to follow the same
Pierrick Bouvier writes:
[...]
> At this point, I would like to focus on having a first version of TargetInfo
> API, and not reviewing any other changes, as things may be modified, and they
> would need to be reviewed again. It's hard to follow the same abstraction
> done multiple times in mu
On 4/19/25 05:54, Philippe Mathieu-Daudé wrote:
I don't think doing strcmp is a good move here, even temporarily.
A short term solution is making target_info.c target specific, and use:
return TARGET_AARCH64;
IIUC as
https://lore.kernel.org/qemu-devel/20231122183048.17150-3-phi...@linaro.org/?
On 19/4/25 03:09, Pierrick Bouvier wrote:
On 4/18/25 10:29, Philippe Mathieu-Daudé wrote:
Add a helper to distinct the binary is targetting
Aarch64 or not.
Start with a dump strcmp() implementation, leaving
room for future optimizations.
Signed-off-by: Philippe Mathieu-Daudé
---
include/qem
On 4/18/25 10:29, Philippe Mathieu-Daudé wrote:
Add a helper to distinct the binary is targetting
Aarch64 or not.
Start with a dump strcmp() implementation, leaving
room for future optimizations.
Signed-off-by: Philippe Mathieu-Daudé
---
include/qemu/target_info.h | 7 +++
target_info.c
Add a helper to distinct the binary is targetting
Aarch64 or not.
Start with a dump strcmp() implementation, leaving
room for future optimizations.
Signed-off-by: Philippe Mathieu-Daudé
---
include/qemu/target_info.h | 7 +++
target_info.c | 5 +
2 files changed, 12 inserti
