Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-05-01 Thread John Snow
On Mon, Apr 24, 2023, 4:02 PM John Snow wrote: > GitLab CI: https://gitlab.com/jsnow/qemu/-/pipelines/846869409 >(All green, except Python self-tests, see below) > > This patch series creates a mandatory python virtual environment > ("venv") during configure time and uses it to ensure

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-26 Thread Paolo Bonzini
On 4/26/23 18:32, John Snow wrote: mkvenv: Creating {isolated|non-isolated} virtual environment [based on /home/pbonzini/myvenv] "based on ..." for nested venv case only? Yes. and when creating the console-scripts shims: mkvenv: Found avocado v90.0 Sure. Up to the user at

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-26 Thread Paolo Bonzini
On 4/26/23 18:16, John Snow wrote: > - I am ambivalent about keeping --enable/--disable-pypi in the first > committed patchset, but in any case I would move patches 16 and 20 > before patch 15 I might be stubborn but I think I want to keep it in for now. If it needs redesigned t

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-26 Thread John Snow
On Wed, Apr 26, 2023, 5:08 AM Paolo Bonzini wrote: > On 4/26/23 10:53, Daniel P. Berrangé wrote: > > I think it'd be useful for support purposes if the configure > > script summary printed details of how we setup the venv. > > eg perhaps a summary for each python module of whether we > > added it

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-26 Thread John Snow
On Wed, Apr 26, 2023, 4:49 AM Paolo Bonzini wrote: > On 4/26/23 10:05, Paolo Bonzini wrote: > >> > > > > Thanks, this looks pretty good. Some changes I'd make for the non-RFC > > version: > > > > - I think we should just check in the meson wheel (which also removes > > the need for patch 12, so

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-26 Thread Paolo Bonzini
On 4/26/23 10:53, Daniel P. Berrangé wrote: I think it'd be useful for support purposes if the configure script summary printed details of how we setup the venv. eg perhaps a summary for each python module of whether we added it to the venv, or relied on te site packages: python venv: meson

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-26 Thread Daniel P . Berrangé
On Mon, Apr 24, 2023 at 04:02:28PM -0400, John Snow wrote: > GitLab CI: https://gitlab.com/jsnow/qemu/-/pipelines/846869409 >(All green, except Python self-tests, see below) > > This patch series creates a mandatory python virtual environment > ("venv") during configure time and uses i

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-26 Thread Paolo Bonzini
On 4/26/23 10:05, Paolo Bonzini wrote: Thanks, this looks pretty good.  Some changes I'd make for the non-RFC version: - I think we should just check in the meson wheel (which also removes the need for patch 12, so it can be done in its stead) and remove the submodule - The verbosity of

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-26 Thread Paolo Bonzini
On 4/26/23 10:21, Daniel P. Berrangé wrote: So if you already have Sphinx, this should perform an upgrade to the latest version? Essentially I meant 'force' to mean*never* use the host python installation packages. Always install all the deps in the venv, even if they exist in the host with su

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-26 Thread Daniel P . Berrangé
On Tue, Apr 25, 2023 at 02:58:53PM -0400, John Snow wrote: > On Tue, Apr 25, 2023 at 2:10 PM Daniel P. Berrangé > wrote: > > How about having --enable-pypi never|auto|force with the following > > semantics for --enable-docs + --enable-pypi > > > > > > * docs=no - pypi never used > > > > * d

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-26 Thread Paolo Bonzini
On 4/24/23 22:02, John Snow wrote: Some important points as a pre-emptive "FAQ": - This venv is unconditionally created and lives at {build_dir}/pyvenv. - The python interpreter used by this venv is always the one identified by configure. (Which in turn is always the one specified by --pytho

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-25 Thread John Snow
On Tue, Apr 25, 2023 at 2:10 PM Daniel P. Berrangé wrote: > > On Tue, Apr 25, 2023 at 01:34:52PM -0400, John Snow wrote: > > On Tue, Apr 25, 2023, 1:22 PM John Snow wrote: > > > > > > > > > > > On Tue, Apr 25, 2023, 1:17 PM Daniel P. Berrangé > > > wrote: > > > > > >> On Mon, Apr 24, 2023 at 04:

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-25 Thread Daniel P . Berrangé
On Tue, Apr 25, 2023 at 01:34:52PM -0400, John Snow wrote: > On Tue, Apr 25, 2023, 1:22 PM John Snow wrote: > > > > > > > On Tue, Apr 25, 2023, 1:17 PM Daniel P. Berrangé > > wrote: > > > >> On Mon, Apr 24, 2023 at 04:02:28PM -0400, John Snow wrote: > >> > GitLab CI: https://gitlab.com/jsnow/qem

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-25 Thread Daniel P . Berrangé
On Tue, Apr 25, 2023 at 01:22:38PM -0400, John Snow wrote: > On Tue, Apr 25, 2023, 1:17 PM Daniel P. Berrangé > wrote: > > > On Mon, Apr 24, 2023 at 04:02:28PM -0400, John Snow wrote: > > > GitLab CI: https://gitlab.com/jsnow/qemu/-/pipelines/846869409 > > >(All green, except Python s

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-25 Thread John Snow
On Tue, Apr 25, 2023, 1:22 PM John Snow wrote: > > > On Tue, Apr 25, 2023, 1:17 PM Daniel P. Berrangé > wrote: > >> On Mon, Apr 24, 2023 at 04:02:28PM -0400, John Snow wrote: >> > GitLab CI: https://gitlab.com/jsnow/qemu/-/pipelines/846869409 >> >(All green, except Python self-tests,

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-25 Thread John Snow
On Tue, Apr 25, 2023, 1:17 PM Daniel P. Berrangé wrote: > On Mon, Apr 24, 2023 at 04:02:28PM -0400, John Snow wrote: > > GitLab CI: https://gitlab.com/jsnow/qemu/-/pipelines/846869409 > >(All green, except Python self-tests, see below) > > > > This patch series creates a mandatory pyt

Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-25 Thread Daniel P . Berrangé
On Mon, Apr 24, 2023 at 04:02:28PM -0400, John Snow wrote: > GitLab CI: https://gitlab.com/jsnow/qemu/-/pipelines/846869409 >(All green, except Python self-tests, see below) > > This patch series creates a mandatory python virtual environment > ("venv") during configure time and uses i

[RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-24 Thread John Snow
GitLab CI: https://gitlab.com/jsnow/qemu/-/pipelines/846869409 (All green, except Python self-tests, see below) This patch series creates a mandatory python virtual environment ("venv") during configure time and uses it to ensure the availability of meson and sphinx. See https://www.qe