Re: [RFC PATCH v2 4/4] target/avr/translate: Fix SBRC/SBRS instructions

2020-07-10 Thread Richard Henderson
On 7/7/20 9:58 AM, Philippe Mathieu-Daudé wrote: > I couldn't run Sarah's test suite on Fedora 30: > > /usr/lib/gcc/avr/9.2.0/../../../../avr/bin/ld: cannot find > crtatmega2560.o: No such file or directory > /usr/lib/gcc/avr/9.2.0/../../../../avr/bin/ld: cannot find -lm > /usr/lib/gcc/avr/9.2.0/.

Re: [RFC PATCH v2 4/4] target/avr/translate: Fix SBRC/SBRS instructions

2020-07-07 Thread Philippe Mathieu-Daudé
On 7/7/20 6:34 PM, Richard Henderson wrote: > On 7/7/20 12:00 AM, Philippe Mathieu-Daudé wrote: >> @@ -1385,7 +1385,7 @@ static bool trans_SBRC(DisasContext *ctx, arg_SBRC *a) >> { >> TCGv Rr = cpu_r[a->rr]; >> >> -ctx->skip_cond = TCG_COND_EQ; >> +ctx->skip_cond = TCG_COND_NE; >>

Re: [RFC PATCH v2 4/4] target/avr/translate: Fix SBRC/SBRS instructions

2020-07-07 Thread Richard Henderson
On 7/7/20 12:00 AM, Philippe Mathieu-Daudé wrote: > @@ -1385,7 +1385,7 @@ static bool trans_SBRC(DisasContext *ctx, arg_SBRC *a) > { > TCGv Rr = cpu_r[a->rr]; > > -ctx->skip_cond = TCG_COND_EQ; > +ctx->skip_cond = TCG_COND_NE; > ctx->skip_var0 = tcg_temp_new(); > ctx->free

[RFC PATCH v2 4/4] target/avr/translate: Fix SBRC/SBRS instructions

2020-07-07 Thread Philippe Mathieu-Daudé
SBRC/SBRS instructions seem to be inverted. Signed-off-by: Philippe Mathieu-Daudé --- target/avr/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index fe03e676df..2f77fe3ba7 100644 --- a/target/avr/translate.c ++