Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

2021-06-11 Thread Stefan Berger
On 6/11/21 4:02 AM, Markus Armbruster wrote: Stefan, would you be willing to look into this? Have a look at the 3 topmost patches: https://github.com/stefanberger/qemu-tpm/commits/tpm-eliminate-if-not-config-tpm

Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

2021-06-11 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 6/10/21 1:06 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 6/10/21 11:33 AM, Markus Armbruster wrote: Eric Blake writes: > On Wed, Jun 09, 2021 at 08:49:54PM +0200, Philippe Mathieu-Daudé wrote: >> In case we need

Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

2021-06-10 Thread Philippe Mathieu-Daudé
On 6/10/21 1:06 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 6/10/21 11:33 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> On Wed, Jun 09, 2021 at 08:49:54PM +0200, Philippe Mathieu-Daudé wrote: > In case we need to use QAPI types but no QAPI command / Q

Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

2021-06-10 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 6/10/21 11:33 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On Wed, Jun 09, 2021 at 08:49:54PM +0200, Philippe Mathieu-Daudé wrote: In case we need to use QAPI types but no QAPI command / QAPI event actually use them, the generated qmp_m

Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

2021-06-10 Thread Philippe Mathieu-Daudé
On 6/10/21 11:33 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On Wed, Jun 09, 2021 at 08:49:54PM +0200, Philippe Mathieu-Daudé wrote: >>> In case we need to use QAPI types but no QAPI command / QAPI event >>> actually use them, the generated qmp_marshal_output() function will >>> trigge

Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

2021-06-10 Thread Markus Armbruster
Eric Blake writes: > On Wed, Jun 09, 2021 at 08:49:54PM +0200, Philippe Mathieu-Daudé wrote: >> In case we need to use QAPI types but no QAPI command / QAPI event >> actually use them, the generated qmp_marshal_output() function will >> trigger the compiler 'unused-function' warnings. >> To preve

Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

2021-06-09 Thread Eric Blake
On Wed, Jun 09, 2021 at 08:49:54PM +0200, Philippe Mathieu-Daudé wrote: > In case we need to use QAPI types but no QAPI command / QAPI event > actually use them, the generated qmp_marshal_output() function will > trigger the compiler 'unused-function' warnings. > To prevent that, emit these functio

[RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

2021-06-09 Thread Philippe Mathieu-Daudé
In case we need to use QAPI types but no QAPI command / QAPI event actually use them, the generated qmp_marshal_output() function will trigger the compiler 'unused-function' warnings. To prevent that, emit these functions inlined: the compiler will ignore such unused functions. Signed-off-by: Phil