Re: [RFC PATCH v2 1/2] Basic PCIe DOE support

2021-03-04 Thread Chris Browy
> On Mar 4, 2021, at 2:21 PM, Jonathan Cameron > wrote: > > On Tue, 9 Feb 2021 15:35:49 -0500 > Chris Browy wrote: > > Hi Chris, > > One more thing hit whilst debugging linux side of this. > >> +static void pcie_doe_irq_assert(DOECap *doe_cap) >> +{ >> +PCIDevice *dev = doe_cap->doe->

Re: [RFC PATCH v2 1/2] Basic PCIe DOE support

2021-03-04 Thread Jonathan Cameron
On Tue, 9 Feb 2021 15:35:49 -0500 Chris Browy wrote: Hi Chris, One more thing hit whilst debugging linux side of this. > +static void pcie_doe_irq_assert(DOECap *doe_cap) > +{ > +PCIDevice *dev = doe_cap->doe->pdev; > + > +if (doe_cap->cap.intr && doe_cap->ctrl.intr) { need something

Re: [RFC PATCH v2 1/2] Basic PCIe DOE support

2021-02-19 Thread Jonathan Cameron
On Thu, 18 Feb 2021 19:46:54 -0500 Chris Browy wrote: > > On Feb 18, 2021, at 2:11 PM, Jonathan Cameron > > wrote: > > > > On Fri, 12 Feb 2021 16:58:21 -0500 > > Chris Browy wrote: > > > >>> On Feb 12, 2021, at 11:24 AM, Jonathan Cameron > >>> wrote: > >>> > >>> On Tue, 9 Feb 2021 15:35

Re: [RFC PATCH v2 1/2] Basic PCIe DOE support

2021-02-18 Thread Chris Browy
> On Feb 18, 2021, at 2:11 PM, Jonathan Cameron > wrote: > > On Fri, 12 Feb 2021 16:58:21 -0500 > Chris Browy wrote: > >>> On Feb 12, 2021, at 11:24 AM, Jonathan Cameron >>> wrote: >>> >>> On Tue, 9 Feb 2021 15:35:49 -0500 >>> Chris Browy wrote: >>> >>> Run ./scripts/checkpatch.pl over

Re: [RFC PATCH v2 1/2] Basic PCIe DOE support

2021-02-18 Thread Jonathan Cameron
On Fri, 12 Feb 2021 16:58:21 -0500 Chris Browy wrote: > > On Feb 12, 2021, at 11:24 AM, Jonathan Cameron > > wrote: > > > > On Tue, 9 Feb 2021 15:35:49 -0500 > > Chris Browy wrote: > > > > Run ./scripts/checkpatch.pl over the patches and fix all the warnings before > > posting. It will save

Re: [RFC PATCH v2 1/2] Basic PCIe DOE support

2021-02-12 Thread Chris Browy
> On Feb 12, 2021, at 11:24 AM, Jonathan Cameron > wrote: > > On Tue, 9 Feb 2021 15:35:49 -0500 > Chris Browy wrote: > > Run ./scripts/checkpatch.pl over the patches and fix all the warnings before > posting. It will save time by clearing out most of the minor formatting > issues > and si

Re: [RFC PATCH v2 1/2] Basic PCIe DOE support

2021-02-12 Thread Jonathan Cameron
On Tue, 9 Feb 2021 15:35:49 -0500 Chris Browy wrote: Run ./scripts/checkpatch.pl over the patches and fix all the warnings before posting. It will save time by clearing out most of the minor formatting issues and similar that inevitably sneak in during development. The biggest issue I'm seeing

Re: [RFC PATCH v2 1/2] Basic PCIe DOE support

2021-02-09 Thread Chris Browy
No consensus yet but I’d suggest that we’ll do the QEMU work and Jonathan focuses on the linux kernel and UEFI/edk2 and CXL SSWG efforts. Seems like a way to maximize resources and everyone’s contribution and expertise. QEMU part requires the least expertise which is why we’re best suited for

Re: [RFC PATCH v2 1/2] Basic PCIe DOE support

2021-02-09 Thread Ben Widawsky
Have you/Jonathan come to consensus about which implementation is going forward? I'd rather not have to review two :D On 21-02-09 15:35:49, Chris Browy wrote: > --- > MAINTAINERS | 7 + > hw/pci/meson.build| 1 + > hw/pci/pcie.c

[RFC PATCH v2 1/2] Basic PCIe DOE support

2021-02-09 Thread Chris Browy
--- MAINTAINERS | 7 + hw/pci/meson.build| 1 + hw/pci/pcie.c | 2 +- hw/pci/pcie_doe.c | 414 ++ include/hw/pci/pci_ids.h | 2 + include/h