Re: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2023-01-16 Thread Jason Wang
On Tue, Jan 17, 2023 at 4:58 AM Michael S. Tsirkin wrote: > > On Wed, Jan 11, 2023 at 01:51:06PM +0800, Jason Wang wrote: > > On Wed, Jan 11, 2023 at 12:40 PM Parav Pandit wrote: > > > > > > > > > > From: Jason Wang > > > > Sent: Tuesday, January 10, 2023 11:35 PM > > > > > > > > On Tue, Jan 10,

Re: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2023-01-16 Thread Jason Wang
On Tue, Jan 17, 2023 at 5:02 AM Michael S. Tsirkin wrote: > > On Wed, Dec 07, 2022 at 09:56:20AM +0100, Eugenio Perez Martin wrote: > > > A dumb question, any reason we need bother with virtio-net? It looks > > > to me it's not a must and would complicate migration compatibility. > > > > > > I gue

Re: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2023-01-16 Thread Michael S. Tsirkin
On Wed, Dec 07, 2022 at 09:56:20AM +0100, Eugenio Perez Martin wrote: > > A dumb question, any reason we need bother with virtio-net? It looks > > to me it's not a must and would complicate migration compatibility. > > > > I guess virtio-blk is the better place. > > > > I'm fine to start with -blk

Re: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2023-01-16 Thread Michael S. Tsirkin
On Wed, Jan 11, 2023 at 01:51:06PM +0800, Jason Wang wrote: > On Wed, Jan 11, 2023 at 12:40 PM Parav Pandit wrote: > > > > > > > From: Jason Wang > > > Sent: Tuesday, January 10, 2023 11:35 PM > > > > > > On Tue, Jan 10, 2023 at 11:02 AM Parav Pandit wrote: > > > > > > > > Hi Jason, > > > > > >

RE: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2023-01-16 Thread Parav Pandit
> From: Jason Wang > Sent: Wednesday, January 11, 2023 12:51 AM > > On Wed, Jan 11, 2023 at 12:40 PM Parav Pandit wrote: > > > > > > > From: Jason Wang > > > Sent: Tuesday, January 10, 2023 11:35 PM > > > > > > On Tue, Jan 10, 2023 at 11:02 AM Parav Pandit wrote: > > > > > > > > Hi Jason, > >

Re: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2023-01-10 Thread Jason Wang
On Wed, Jan 11, 2023 at 12:40 PM Parav Pandit wrote: > > > > From: Jason Wang > > Sent: Tuesday, January 10, 2023 11:35 PM > > > > On Tue, Jan 10, 2023 at 11:02 AM Parav Pandit wrote: > > > > > > Hi Jason, > > > > > > > From: Jason Wang > > > > Sent: Monday, December 5, 2022 10:25 PM > > > > >

RE: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2023-01-10 Thread Parav Pandit
> From: Jason Wang > Sent: Tuesday, January 10, 2023 11:35 PM > > On Tue, Jan 10, 2023 at 11:02 AM Parav Pandit wrote: > > > > Hi Jason, > > > > > From: Jason Wang > > > Sent: Monday, December 5, 2022 10:25 PM > > > > > > > > A dumb question, any reason we need bother with virtio-net? It looks

Re: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2023-01-10 Thread Jason Wang
On Tue, Jan 10, 2023 at 11:02 AM Parav Pandit wrote: > > Hi Jason, > > > From: Jason Wang > > Sent: Monday, December 5, 2022 10:25 PM > > > > > A dumb question, any reason we need bother with virtio-net? It looks to me > > it's > > not a must and would complicate migration compatibility. > > Vir

RE: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2023-01-09 Thread Parav Pandit
Hi Jason, > From: Jason Wang > Sent: Monday, December 5, 2022 10:25 PM > > A dumb question, any reason we need bother with virtio-net? It looks to me > it's > not a must and would complicate migration compatibility. Virtio net vdpa device is processing the descriptors out of order. This vdpa

Re: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2022-12-07 Thread Eugenio Perez Martin
On Tue, Dec 6, 2022 at 4:24 AM Jason Wang wrote: > > On Tue, Dec 6, 2022 at 1:05 AM Eugenio Pérez wrote: > > > > There is currently no data to be migrated, since nothing populates or > > read the fields on virtio-net. > > > > The migration of in-flight descriptors is modelled after the migration

Re: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2022-12-07 Thread Eugenio Perez Martin
On Mon, Dec 5, 2022 at 9:52 PM Parav Pandit wrote: > > > > From: Eugenio Pérez > > Sent: Monday, December 5, 2022 12:05 PM > > > > There is currently no data to be migrated, since nothing populates or read > > the fields on virtio-net. > > > > The migration of in-flight descriptors is modelled af

Re: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2022-12-05 Thread Jason Wang
On Tue, Dec 6, 2022 at 1:05 AM Eugenio Pérez wrote: > > There is currently no data to be migrated, since nothing populates or > read the fields on virtio-net. > > The migration of in-flight descriptors is modelled after the migration > of requests in virtio-blk. With some differences: > * virtio-b

RE: [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2022-12-05 Thread Parav Pandit
> From: Eugenio Pérez > Sent: Monday, December 5, 2022 12:05 PM > > There is currently no data to be migrated, since nothing populates or read > the fields on virtio-net. > > The migration of in-flight descriptors is modelled after the migration of > requests in virtio-blk. With some difference

[RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors

2022-12-05 Thread Eugenio Pérez
There is currently no data to be migrated, since nothing populates or read the fields on virtio-net. The migration of in-flight descriptors is modelled after the migration of requests in virtio-blk. With some differences: * virtio-blk migrates queue number on each request. Here we only add a vq